Skip to contentSkip to conversation

pci: virtio: use pci id defines.

PATCH New Gerd Hoffmann 1 participant 1 message Dec 11, 2008

lore
Share & tools
lore

Gerd Hoffmann

author
#0 lore raw

PATCH 1/1 pci: virtio: use pci id defines.

Hi,

Use the defines added by the previous patch in the virtio drivers. Also remove the pointless vendor and device args from the virtio_blk_init() function.

please apply,
Gerd

Quoted 1 line

From 47472ad689b422de944b761c9397ada7d80763f2 Mon Sep 17 00:00:00 2001

From: Gerd Hoffmann <[email protected]>
Date: Thu, 11 Dec 2008 15:29:48 +0100
Subject: [PATCH] pci: virtio: use pci id defines.

Use the defines added by the previous patch in the virtio drivers. Also remove the pointless vendor and device args from the virtio_blk_init() function.

Signed-off-by Gerd Hoffmann <[email protected]>
---
 hw/pc.c             |    3 +--
 hw/virtio-balloon.c |    3 ++-
 hw/virtio-blk.c     |    7 ++++---
 hw/virtio-blk.h     |    3 +--
 4 files changed, 8 insertions(+), 8 deletions(-)
hw/pc.c +1 -2
index 20827f2..73dd8bc 100644
@@ -1101,8 +1101,7 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
         int unit_id = 0;
 
         while ((index = drive_get_index(IF_VIRTIO, 0, unit_id)) != -1) {
-            virtio_blk_init(pci_bus, 0x1AF4, 0x1001,
-                            drives_table[index].bdrv);
+            virtio_blk_init(pci_bus, drives_table[index].bdrv);
             unit_id++;
         }
     }
hw/virtio-balloon.c +2 -1
index e668436..0765516 100644
@@ -172,7 +172,8 @@ void *virtio_balloon_init(PCIBus *bus)
     VirtIOBalloon *s;
 
     s = (VirtIOBalloon *)virtio_init_pci(bus, "virtio-balloon",
-                                         6900, 0x1002,
+                                         PCI_VENDOR_ID_REDHAT_QUMRANET,
+                                         PCI_DEVICE_ID_VIRTIO_BALLOON,
                                          0, VIRTIO_ID_BALLOON,
                                          0x05, 0x00, 0x00,
                                          8, sizeof(VirtIOBalloon));
hw/virtio-blk.c +4 -3
index 91b90d2..e654cc5 100644
@@ -218,14 +218,15 @@ static int virtio_blk_load(QEMUFile *f, void *opaque, int version_id)
     return 0;
 }
 
-void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
-                      BlockDriverState *bs)
+void *virtio_blk_init(PCIBus *bus, BlockDriverState *bs)
 {
     VirtIOBlock *s;
     int cylinders, heads, secs;
     static int virtio_blk_id;
 
-    s = (VirtIOBlock *)virtio_init_pci(bus, "virtio-blk", vendor, device,
+    s = (VirtIOBlock *)virtio_init_pci(bus, "virtio-blk",
+                                       PCI_VENDOR_ID_REDHAT_QUMRANET,
+                                       PCI_DEVICE_ID_VIRTIO_BLOCK,
                                        0, VIRTIO_ID_BLOCK,
                                        0x01, 0x80, 0x00,
                                        sizeof(struct virtio_blk_config), sizeof(VirtIOBlock));
hw/virtio-blk.h +1 -2
index c6661c0..8c91e1e 100644
@@ -70,7 +70,6 @@ struct virtio_blk_inhdr
     unsigned char status;
 };
 
-void *virtio_blk_init(PCIBus *bus, uint16_t vendor, uint16_t device,
-                      BlockDriverState *bs);
+void *virtio_blk_init(PCIBus *bus, BlockDriverState *bs);
 
 #endif
Signature · 1 line
1.5.6.5