Skip to contentSkip to conversation

mISDN: consistently define 'debug' as '*u_int'

PATCH Applied Hannes Eder 2 participants 2 messages Dec 11, 2008 – Dec 13, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 2/9 mISDN: consistently define 'debug' as '*u_int'

Impact: change data type for variable 'debug' from *int to *u_int, same for the argument type of mISDN_inittimer

In "core.h" mISDN_inittimer is declared with the argument type "*u_int", make the definition in "timerdev.c" match this.

This fixes also this warnings:

drivers/isdn/mISDN/layer1.c:391:8: warning: incorrect type in assignment (different signedness)
drivers/isdn/mISDN/layer1.c:391:8: expected int *static [toplevel] debug
drivers/isdn/mISDN/layer1.c:391:8: got unsigned int [usertype] *deb
drivers/isdn/mISDN/layer2.c:2200:8: warning: incorrect type in assignment (different signedness)
drivers/isdn/mISDN/layer2.c:2200:8: expected int *static [toplevel] debug
drivers/isdn/mISDN/layer2.c:2200:8: got unsigned int [usertype] *deb
drivers/isdn/mISDN/socket.c:769:8: warning: incorrect type in assignment (different signedness)
drivers/isdn/mISDN/socket.c:769:8: expected int *static [toplevel] debug
drivers/isdn/mISDN/socket.c:769:8: got unsigned int [usertype] *deb

---
 drivers/isdn/mISDN/layer1.c   |    2 +-
 drivers/isdn/mISDN/layer2.c   |    2 +-
 drivers/isdn/mISDN/socket.c   |    2 +-
 drivers/isdn/mISDN/timerdev.c |    4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/isdn/mISDN/layer1.c +1 -1
index fced1a2..4a55d63 100644
@@ -21,7 +21,7 @@
 #include "layer1.h"
 #include "fsm.h"
 
-static int *debug;
+static u_int *debug;
 
 struct layer1 {
 	u_long			Flags;
drivers/isdn/mISDN/layer2.c +1 -1
index a7915a1..77fca3b 100644
@@ -18,7 +18,7 @@
 #include "fsm.h"
 #include "layer2.h"
 
-static int *debug;
+static u_int *debug;
 
 static
 struct Fsm l2fsm = {NULL, 0, 0, NULL, NULL};
drivers/isdn/mISDN/socket.c +1 -1
index e5a20f9..37a2de1 100644
@@ -18,7 +18,7 @@
 #include <linux/mISDNif.h>
 #include "core.h"
 
-static int	*debug;
+static u_int	*debug;
 
 static struct proto mISDN_proto = {
 	.name		= "misdn",
drivers/isdn/mISDN/timerdev.c +2 -2
index 875fabe..a8d1d9f 100644
@@ -24,7 +24,7 @@
 #include <linux/module.h>
 #include <linux/mISDNif.h>
 
-static int	*debug;
+static u_int	*debug;
 
 
 struct mISDNtimerdev {
@@ -274,7 +274,7 @@ static struct miscdevice mISDNtimer = {
 };
 
 int
-mISDN_inittimer(int *deb)
+mISDN_inittimer(u_int *deb)
 {
 	int	err;
 
Signature · 1 line
1.5.6.3
maintainer Applied
#1 lore raw

From: Hannes Eder <[email protected]>
Date: Thu, 11 Dec 2008 22:36:00 +0100

Quoted 7 lines

Impact: change data type for variable 'debug' from *int to *u_int, same for the argument type of mISDN_inittimer

In "core.h" mISDN_inittimer is declared with the argument type "*u_int", make the definition in "timerdev.c" match this.

This fixes also this warnings:

...

Quoted 2 lines

Applied.