Skip to contentSkip to conversation

mISDN: hfcmulti: use __iomem address space modifier

PATCH Applied Hannes Eder 2 participants 2 messages Dec 11, 2008 – Dec 13, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 9/9 mISDN: hfcmulti: use __iomem address space modifier

Impact: make use of the __iomem address space modifier, and change u_char *, u_short * and u_int * to void *

Fix more than 30 sparse warnings of this or similar type:

drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: warning: incorrect type in argument 2 (different address spaces)
drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: got unsigned char [usertype] *
drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: expected void volatile [noderef] <asn:2>*addr

---
 drivers/isdn/hardware/mISDN/hfc_multi.h |    4 +-
 drivers/isdn/hardware/mISDN/hfcmulti.c  |   44 ++++++++++++++++--------------
 2 files changed, 25 insertions(+), 23 deletions(-)
drivers/isdn/hardware/mISDN/hfc_multi.h +2 -2
index a33d87a..7bbf730 100644
@@ -162,8 +162,8 @@ struct hfc_multi {
 	void		(*write_fifo)(struct hfc_multi *hc, u_char *data,
 				int len);
 	u_long		pci_origmembase, plx_origmembase, dsp_origmembase;
-	u_char		*pci_membase; /* PCI memory (MUST BE BYTE POINTER) */
-	u_char		*plx_membase; /* PLX memory */
+	void __iomem	*pci_membase; /* PCI memory */
+	void __iomem	*plx_membase; /* PLX memory */
 	u_char		*dsp_membase; /* DSP on PLX */
 	u_long		pci_iobase; /* PCI IO */
 	struct hfcm_hw	hw;	/* remember data of write-only-registers */
drivers/isdn/hardware/mISDN/hfcmulti.c +23 -21

153 lines not on this page · raw message

Signature · 1 line
1.5.6.3
maintainer Applied
#1 lore raw

From: Hannes Eder <[email protected]>
Date: Thu, 11 Dec 2008 22:36:00 +0100

Quoted 11 lines

Impact: make use of the __iomem address space modifier, and change u_char *, u_short * and u_int * to void *

Fix more than 30 sparse warnings of this or similar type:

drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: warning: incorrect type in argument 2 (different address spaces)
drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: got unsigned char [usertype] *
drivers/isdn/hardware/mISDN/hfcmulti.c:261:31: expected void volatile [noderef] <asn:2>*addr

Applied.