video: mbp_nvidia_bl: Add a debug switch

PATCH In review Mario Schwalbe 1 participant 1 message Dec 12, 2008 1 message not in the archive

Subsystems (2)

Framebuffer layer Backlight class/subsystem

Share & tools

A message that is not in the archive (sent off-list or not yet received): 2e9ff482f36dc7e7694141df51ea977a52474089.1229087880.git.mario@snoopy.(none)

Mario Schwalbe

author

2008-12-12 20:50 UTC #1 lore raw

PATCH 2/2 video: mbp_nvidia_bl: Add a debug switch

This patch adds a debug switch to enable (little) diagnostic output, to help to trace down the remaining problems.

Signed-off-by Mario Schwalbe <[email protected]>

---
 drivers/video/backlight/mbp_nvidia_bl.c |   37 +++++++++++++++++++++++++++++-
 1 files changed, 35 insertions(+), 2 deletions(-)

drivers/video/backlight/mbp_nvidia_bl.c +35 -2

index 559daf0..f014399 100644
@@ -33,6 +33,11 @@ struct dmi_match_data {
 	struct backlight_ops backlight_ops;
 };
 
+/* Module parameters. */
+static int debug;
+module_param_named(debug, debug, int, 0644);
+MODULE_PARM_DESC(debug, "Set to one to enable debugging messages.");
+
 /*
  * Implementation for MacBooks with Intel chipset.
  */

@@ -40,6 +45,10 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
 {
 	int intensity = bd->props.brightness;
 
+	if (debug)
+		printk(KERN_DEBUG "mbp_nvidia_bl: setting brightness to %d\n",
+		       intensity);
+
 	outb(0x04 | (intensity << 4), 0xb3);
 	outb(0xbf, 0xb2);
 	return 0;

@@ -47,9 +56,17 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
 
 static int intel_chipset_get_intensity(struct backlight_device *bd)
 {
+	int intensity;
+
 	outb(0x03, 0xb3);
 	outb(0xbf, 0xb2);
-	return inb(0xb3) >> 4;
+	intensity = inb(0xb3) >> 4;
+
+	if (debug)
+		printk(KERN_DEBUG "mbp_nvidia_bl: read brightness of %d\n",
+		       intensity);
+
+	return intensity;
 }
 
 static const struct dmi_match_data intel_chipset_data = {

@@ -72,6 +89,10 @@ static int nvidia_chipset_send_intensity(struct backlight_device *bd)
 {
 	int intensity = bd->props.brightness;
 
+	if (debug)
+		printk(KERN_DEBUG "mbp_nvidia_bl: setting brightness to %d\n",
+		       intensity);
+
 	outb(0x04 | (intensity << 4), 0x52f);
 	outb(0xbf, 0x52e);
 	return 0;

@@ -79,9 +100,17 @@ static int nvidia_chipset_send_intensity(struct backlight_device *bd)
 
 static int nvidia_chipset_get_intensity(struct backlight_device *bd)
 {
+	int intensity;
+
 	outb(0x03, 0x52f);
 	outb(0xbf, 0x52e);
-	return inb(0x52f) >> 4;
+	intensity = inb(0x52f) >> 4;
+
+	if (debug)
+		printk(KERN_DEBUG "mbp_nvidia_bl: read brightness of %d\n",
+		       intensity);
+
+	return intensity;
 }
 
 static const struct dmi_match_data nvidia_chipset_data = {

@@ -211,6 +240,10 @@ static int mbp_resume(struct platform_device *pdev)
 	 */
 	struct backlight_device *bd = platform_get_drvdata(pdev);
 
+	if (debug)
+		printk(KERN_DEBUG "mbp_nvidia_bl: resuming with"
+		       " brightness %d\n", bd->props.brightness);
+
 	backlight_update_status(bd);
 	return 0;
 }

Signature · 1 line

1.5.6.3