Skip to contentSkip to conversation

x86-2.6.27: Cleanup redundant mtrr hunk

PATCH In review Jan Kiszka 2 participants 5 messages Dec 16, 2008 x86

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 x86-2.6.27: Cleanup redundant mtrr hunk

Likely a merge artifact: IRQs are already reenabled a few lines above this hunk.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -1
Index: b/arch/x86/kernel/cpu/mtrr/generic.c
===================================================================
@@ -575,7 +575,7 @@ static void generic_set_all(void)
 			set_bit(count, &smp_changes_mask);
 		mask >>= 1;
 	}
-	local_irq_restore_hw(flags);
+	
 }
 
 static void generic_set_mtrr(unsigned int reg, unsigned long base,
#1 lore raw

I rebooted my laptop 10 minutes ago and the problem happens again!

Roberto

Quoted 27 lines · On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:

Likely a merge artifact: IRQs are already reenabled a few lines above this hunk.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/x86/kernel/cpu/mtrr/generic.c
===================================================================

arch/x86/kernel/cpu/mtrr/generic.c +1 -1
@@ -575,7 +575,7 @@ static void generic_set_all(void)
 			set_bit(count, &smp_changes_mask);
 		mask >>= 1;
 	}
-	local_irq_restore_hw(flags);
+
 }
 
 static void generic_set_mtrr(unsigned int reg, unsigned long base,

_______________________________________________
Adeos-main mailing list
[email protected]
https://mail.gna.org/listinfo/adeos-main

Signature · 4 lines
University of Applied Sciences of Southern Switzerland
Dept. Innovative Technologies
CH-6928 Lugano-Manno
http://web.dti.supsi.ch/~bucher
author
#2 lore raw
Quoted 2 lines · Roberto Bucher

I rebooted my laptop 10 minutes ago and the problem happens again!

Grmbl. Still no chance to get hold of an oops message?

Jan

Quoted 31 lines

Roberto

Quoted 27 lines · On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:

Likely a merge artifact: IRQs are already reenabled a few lines above this hunk.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/x86/kernel/cpu/mtrr/generic.c
===================================================================

arch/x86/kernel/cpu/mtrr/generic.c +1 -1
@@ -575,7 +575,7 @@ static void generic_set_all(void)
 			set_bit(count, &smp_changes_mask);
 		mask >>= 1;
 	}
-	local_irq_restore_hw(flags);
+
 }
 
 static void generic_set_mtrr(unsigned int reg, unsigned long base,

_______________________________________________
Adeos-main mailing list
[email protected]
https://mail.gna.org/listinfo/adeos-main

Signature · 2 lines
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux
#3 lore raw

I'm sorry but my system freezes without giving some info in the log files...

I don't know exactly what I can do: basically I can reproduce the error, but I can't catch any log info about.

Roberto

Quoted 37 lines · On Tuesday 16 December 2008 13:49:23 you wrote:
Quoted 1 line · Roberto Bucher

I rebooted my laptop 10 minutes ago and the problem happens again!

Grmbl. Still no chance to get hold of an oops message?

Jan

Quoted 30 lines

Roberto

Quoted 27 lines · On Tuesday 16 December 2008 10:43:48 Jan Kiszka wrote:

Likely a merge artifact: IRQs are already reenabled a few lines above this hunk.

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/x86/kernel/cpu/mtrr/generic.c
===================================================================

arch/x86/kernel/cpu/mtrr/generic.c +1 -1
@@ -575,7 +575,7 @@ static void generic_set_all(void)
 			set_bit(count, &smp_changes_mask);
 		mask >>= 1;
 	}
-	local_irq_restore_hw(flags);
+
 }
 
 static void generic_set_mtrr(unsigned int reg, unsigned long base,

_______________________________________________
Adeos-main mailing list
[email protected]
https://mail.gna.org/listinfo/adeos-main

Signature · 4 lines
University of Applied Sciences of Southern Switzerland
Dept. Innovative Technologies
CH-6928 Lugano-Manno
http://web.dti.supsi.ch/~bucher
author
#4 lore raw
Quoted 5 lines · Roberto Bucher

I'm sorry but my system freezes without giving some info in the log files...

I don't know exactly what I can do: basically I can reproduce the error, but I can't catch any log info about.

Please have a look at linux/Documentation/serial-console.txt or linux/Documentation/networking/netconsole.txt.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT SE 26
Corporate Competence Center Embedded Linux