Skip to contentSkip to conversation

avoid kvm-userspace merge conflict with PowerPC KVM support in qemu

PATCH Applied Hollis Blanchard 2 participants 2 messages Dec 16, 2008 – Dec 17, 2008 1 message not in the archive KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 avoid kvm-userspace merge conflict with PowerPC KVM support in qemu

PowerPC KVM support was accepted into upstream qemu. To ease the merge conflicts, you should apply this patch to remove all traces of PowerPC KVM code from kvm-userspace before the next qemu pull.

---
You'll also want to remove qemu/pc-bios/bamboo.dtb, which I can't express in this patch because guilt sucks.

Sorry if I missed anything; let me know if you you have problems.

qemu/Makefile +0 -1
index b2ca039..745851d 100644
@@ -228,7 +228,6 @@ BLOBS=bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin \
 video.x openbios-sparc32 openbios-sparc64 pxe-ne2k_pci.bin \
 pxe-rtl8139.bin pxe-pcnet.bin pxe-e1000.bin
 BLOBS += extboot.bin
-BLOBS += bamboo.dtb
 else
 BLOBS=
 endif
qemu/Makefile.target +0 -12
index 315c3c9..a304570 100644
@@ -231,12 +231,6 @@ LIBOBJS+=qemu-kvm-helper.o
 endif
 endif
 
-ifeq ($(TARGET_BASE_ARCH), ppc)
-ifeq ($(USE_KVM), 1)
-LIBOBJS+= qemu-kvm-powerpc.o
-endif
-endif
-
 LIBOBJS+= op_helper.o
 
 ifneq ($(TARGET_ARCH), ia64)
@@ -679,11 +673,6 @@ ifdef CONFIG_BLUEZ
 LIBS += $(CONFIG_BLUEZ_LIBS)
 endif
 
-ifdef CONFIG_LIBFDT
-LIBS += -lfdt
-DEPLIBS += ../libfdt/libfdt.a
-endif
-
 # SCSI layer
 OBJS+= lsi53c895a.o esp.o
 
@@ -747,7 +736,6 @@ OBJS+= heathrow_pic.o grackle_pci.o ppc_oldworld.o
 OBJS+= unin_pci.o ppc_chrp.o
 # PowerPC 4xx boards
 OBJS+= pflash_cfi02.o ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o
-OBJS+= ppc440.o ppc440_bamboo.o device_tree.o
 # virtio support
 OBJS+= virtio.o virtio-blk.o virtio-balloon.o
 OBJS+= virtio-net.o
qemu/configure +0 -36
index 5f5264f..468896e 100755
@@ -124,7 +124,6 @@ blobs="yes"
 signalfd="no"
 eventfd="no"
 cpu_emulation="yes"
-device_tree_support=""
 
 # OS specific
 targetos=`uname -s`
@@ -389,8 +388,6 @@ for opt do
   ;;
   --disable-cpu-emulation) cpu_emulation="no"
   ;;
-  --disable-libfdt) device_tree_support="no"
-  ;;
   *) echo "ERROR: unknown option $opt"; exit 1
   ;;
   esac
@@ -503,7 +500,6 @@ echo "  --disable-aio            disable AIO support"
 echo "  --disable-blobs          disable installing provided firmware blobs"
 echo "  --kerneldir=PATH         look for kernel includes in PATH"
 echo "  --disable-cpu-emulation  disables use of qemu cpu emulation code"
-echo "  --disable-libfdt         disables use of libfdt support for device tree"
 echo ""
 echo "NOTE: The object files are built at the place where configure is launched"
 exit 1
@@ -1092,31 +1088,6 @@ else
   binsuffix="/bin"
 fi
 
-######################################
-# libfdt probe
-#
-if test -z "$device_tree_support" -a \
-   "$cpu" = "powerpc"; then
-  device_tree_support="no"
-  cat > $TMPC << EOF
-#include <libfdt.h>
-/* XXX uncomment later when libfdt is built before this test */
-//int main(void) { void *fdt; return fdt_create(fdt, 1024); }
-int main (void) {return 0;}
-EOF
-# XXX for now do not try to link to libfdt and just check for header */
-# if $cc $ARCH_CFLAGS $CFLAGS $LDFLAGS -o $TMPE $TMPC -lfdt 2> /dev/null ; then
-  if $cc $ARCH_CFLAGS $CFLAGS $LDFLAGS -o $TMPE $TMPC 2> /dev/null; then
-   device_tree_support="yes"
-  else
-    echo
-    echo "Error: Could not find libfdt"
-    echo "Make sure to have the libfdt libs and headers installed."
-    echo
-    exit 1
-  fi
-fi
-
 echo "Install prefix    $prefix"
 echo "BIOS directory    $prefix$datasuffix"
 echo "binary directory  $prefix$binsuffix"
@@ -1161,9 +1132,6 @@ fi
 echo "kqemu support     $kqemu"
 echo "kvm support       $kvm"
 echo "CPU emulation     $cpu_emulation"
-if test $cpu = "powerpc"; then
-echo "libfdt support    $device_tree_support"
-fi
 echo "brlapi support    $brlapi"
 echo "Documentation     $build_docs"
 [ ! -z "$uname_release" ] && \
@@ -1726,10 +1694,6 @@ case "$target_cpu" in
     echo "#define TARGET_ARCH \"ppcemb\"" >> $config_h
     echo "#define TARGET_PPC 1" >> $config_h
     echo "#define TARGET_PPCEMB 1" >> $config_h
-    if test "$device_tree_support" = "yes" ; then
-	echo "#define CONFIG_LIBFDT 1" >> $config_h
-	echo "CONFIG_LIBFDT=1" >> $config_mak
-    fi
     configure_kvm
   ;;
   ppc64)
qemu/hw/boards.h +0 -1
index d2b26c6..fae6d19 100644
@@ -40,7 +40,6 @@ extern QEMUMachine core99_machine;
 extern QEMUMachine heathrow_machine;
 extern QEMUMachine ref405ep_machine;
 extern QEMUMachine taihu_machine;
-extern QEMUMachine bamboo_machine;
 
 /* mips_r4k.c */
 extern QEMUMachine mips_machine;
qemu/hw/device_tree.c deleted +0 -193

193 lines not on this page · raw message

qemu/hw/device_tree.h deleted +0 -26
deleted file mode 100644
index a311309..0000000
@@ -1,26 +0,0 @@
-/*
- * Header with function prototypes to help device tree manipulation using
- * libfdt. It also provides functions to read entries from device tree proc
- * interface.
- *
- * Copyright 2008 IBM Corporation.
- * Authors: Jerone Young <jyoung5-r/[email protected]>
- *
- * This work is licensed under the GNU GPL license version 2 or later.
- *
- */
-
-/* device-tree proc support functions */
-uint32_t read_proc_dt_prop_cell(const char *path_in_device_tree);
-
-#ifdef CONFIG_LIBFDT
-/* device tree functions */
-void *load_device_tree(const char *filename_path, target_ulong load_addr);
-void dump_device_tree_to_file(void *fdt, const char *filename);
-void dt_cell(void *fdt, const char *node_path, const char *property,
-		uint32_t val);
-void dt_cell_multi(void *fdt, const char *node_path, const char *property,
-		uint32_t *val_array, int size);
-void dt_string(void *fdt, const char *node_path, const char *property,
-		char *string);
-#endif
qemu/hw/ppc440.c deleted +0 -83

83 lines not on this page · raw message

qemu/hw/ppc440.h deleted +0 -35
deleted file mode 100644
index 9523f94..0000000
@@ -1,35 +0,0 @@
-/*
- * Qemu PowerPC 440 board emualtion
- *
- * Copyright 2007 IBM Corporation.
- * Authors: Jerone Young <jyoung5-r/[email protected]>
- * 	    Christian Ehrhardt <[email protected]>
- *
- * This work is licensed under the GNU GPL licence version 2 or later
- *
- */
-
-#ifndef QEMU_PPC440_H
-#define QEMU_PPC440_H
-
-#include "hw.h"
-#include "ppc.h"
-#include "ppc405.h"
-#include "pc.h"
-#include "qemu-timer.h"
-#include "sysemu.h"
-#include "exec-all.h"
-#include "boards.h"
-#include "pci.h"
-
-#define PPC440_MAX_RAM_SLOTS 4
-
-void ppc440ep_init(CPUState *env,
-		target_phys_addr_t ram_bases[PPC440_MAX_RAM_SLOTS],
-		target_phys_addr_t ram_sizes[PPC440_MAX_RAM_SLOTS],
-		int nbanks,
-		qemu_irq **picp,
-		PCIBus **pcip,
-		int do_init);
-
-#endif
qemu/hw/ppc440_bamboo.c deleted +0 -227

227 lines not on this page · raw message

qemu/pc-bios/bamboo.dts deleted +0 -234

234 lines not on this page · raw message

qemu/qemu-kvm-powerpc.c deleted +0 -217

217 lines not on this page · raw message

qemu/target-ppc/machine.c +0 -1
index ea2257b..be0cbe1 100644
@@ -8,7 +8,6 @@ void register_machines(void)
     qemu_register_machine(&prep_machine);
     qemu_register_machine(&ref405ep_machine);
     qemu_register_machine(&taihu_machine);
-    qemu_register_machine(&bamboo_machine);
 }
 
 void cpu_save(QEMUFile *f, void *opaque)
Signature · 7 lines
Hollis Blanchard
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1229470067.19354.5.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]

Applied
#2 lore raw
Quoted 5 lines · Hollis Blanchard

PowerPC KVM support was accepted into upstream qemu. To ease the merge conflicts, you should apply this patch to remove all traces of PowerPC KVM code from kvm-userspace before the next qemu pull.

Applied, thanks.

Signature · 6 lines
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html