gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.
PATCH 1/1 gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.
From: Johannes Sixt <[email protected]>
The button order 'prev' left of 'next' feels more natural than the other way round, in particular, compared to the order of the forward and backward arrows that are in the line above.
--- gitk-git/gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
gitk-git/gitk +1 -1
@@ -2052,7 +2052,7 @@ proc makewindow {} { button .tf.lbar.fnext -text [mc "next"] -command {dofind 1 1} button .tf.lbar.fprev -text [mc "prev"] -command {dofind -1 1} label .tf.lbar.flab2 -text " [mc "commit"] " - pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \ + pack .tf.lbar.flabel .tf.lbar.fprev .tf.lbar.fnext .tf.lbar.flab2 \ -side left -fill y set gdttype [mc "containing:"] set gm [tk_optionMenu .tf.lbar.gdttype gdttype \
Signature · 1 line
1.6.1.rc3.980.ga0bb
Quoted 3 lines · Johannes Sixt
The button order 'prev' left of 'next' feels more natural than the other way round, in particular, compared to the order of the forward and backward arrows that are in the line above.
The next/prev labels are a bit awkward in any case, since "next" finds an earlier commit - one further down the list, and "prev" finds a later commit - one further back in the list. A better solution might be to make images for arrows pointing up and down and use compound buttons so the buttons say Find ^ and Find v (if you image the ^/v as up and down arrows).
I also find myself often wanting a "Find first" button, i.e. search starting at the top of the list.
Paul.