Skip to contentSkip to conversation

check for maximal device size in set_lv

PATCH New Milan Broz 2 participants 2 messages Dec 19, 2008

lore
Share & tools
lore

Milan Broz

author
#0 lore raw

PATCH 1/1 check for maximal device size in set_lv

Do not issue write violating LV size.

pvcreate $DEV
vgcreate -s 1k vg_test $DEV
lvcreate -l 1 -n lv1 vg_test
..
/dev/vg_test/lv1: write failed after 1024 of 4096 at 0: No space left on device

Just check for maximum write size in set_lv.

Signed-off-by Milan Broz <[email protected]>
---
 lib/metadata/lv_manip.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
lib/metadata/lv_manip.c +7 -3
Index: LVM2/lib/metadata/lv_manip.c
===================================================================
@@ -2698,9 +2698,13 @@ int set_lv(struct cmd_context *cmd, stru
 	if (!dev_open_quiet(dev))
 		return_0;
 
-	dev_set(dev, UINT64_C(0),
-		sectors ? (size_t) sectors << SECTOR_SHIFT : (size_t) 4096,
-		value);
+	if (!sectors)
+		sectors = 4096 >> SECTOR_SHIFT;
+
+	if (sectors > lv->size)
+		sectors = lv->size;
+
+	dev_set(dev, UINT64_C(0), (size_t) sectors << SECTOR_SHIFT, value);
 	dev_flush(dev);
 	dev_close_immediate(dev);
#1 lore raw

PATCH 1/1 check for maximal device size in set_lv

Quoted 1 line · Milan Broz

Do not issue write violating LV size.

Ack.

Alasdair

Signature · 1 line
agk at redhat.com