Skip to contentSkip to conversation

MC44S803 frontend

linux-dvb Jochen Friedrich 5 participants 20 messages Dec 19, 2008 – Jan 17, 2009 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
#2 lore raw
Quoted 10 lines · Jochen Friedrich

Hi Roberto,

Quoted 2 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 7 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Is it possible to add this driver to the linuxtv.org repo? My, or Manu or you? Looks like there is only one device using this driver currently.

Also Manu's original mxl500x driver seems to be much more sensitive than current mxl5005s. I don't know what we should do with this driver, but from users perspective this situation is not good. There is rather many devices using this tuner.

Quoted 3 lines

Thanks,
Jochen

regards
Antti

Signature · 6 lines
http://palosaari.fi/

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#3 lore raw

Hi Antti,

Quoted 2 lines

Is it possible to add this driver to the linuxtv.org repo? My, or Manu or you? Looks like there is only one device using this driver currently.

IMHO it would be best to add this to your AF9015 tree. I hope with the now reduced memory size there is no more reason to reject this driver from being included in the kernel source.

Unfortunately, I'm on holidays for the next two weeks and I don't know if I have internet connectivity all the time.

Quoted 4 lines

Also Manu's original mxl500x driver seems to be much more sensitive than current mxl5005s. I don't know what we should do with this driver, but from users perspective this situation is not good. There is rather many devices using this tuner.

Sorry, but I don't have this chip so I can't comment on this one.

Thanks,
Jochen

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#4 lore raw
In reply to Antti Palosaari
Quoted 27 lines · Antti Palosaari
Quoted 16 lines · Jochen Friedrich

Hi Roberto,

Quoted 2 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a
4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

Quoted 9 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bd e668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bd e668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/
common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb =4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Quoted 8 lines

Is it possible to add this driver to the linuxtv.org repo? My, or Manu or you? Looks like there is only one device using this driver currently.

Also Manu's original mxl500x driver seems to be much more sensitive than current mxl5005s. I don't know what we should do with this driver, but from users perspective this situation is not good. There is rather many devices using this tuner.

Are your drive using MXL_TF_DEFAULT?
I noticed that in the new driver MXL_TF_DEFAULT is missing in the code.

Jose Alberto

Quoted 5 lines
Quoted 2 lines

Thanks,
Jochen

regards
Antti

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#5 lore raw
In reply to Jochen Friedrich
Quoted 10 lines · Jochen Friedrich

Hi Roberto,

Quoted 2 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 7 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Hi Jochen,

thank you for your work. I see the table values are gone and parameters are computed by the code.

I will only be able to test this driver in a couple of days, as I do not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.

Do you prefer me to apply the patch to one tree in particular?

Signature · 6 lines
   Roberto Ragusa    mail at robertoragusa.it

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#6 lore raw

Hi All,
from Roberto's latest posting I see that there is some effort in solving my shortly before reported problem. As an owner of a Cinergy T USB XE Ver.2- stick which works fine under WXP I am bothering for a while i.o. to get rid of problems running it under linux. Could anyone please list some easy steps how I can set up a working hardwaredriver? Currently I have installed: 1. Driver for Afatech 9015, 2. Driver for devices based on Afatech 9015, driver for the AF901x demodulator. The first is reported as being activated and in use, the latter two which are bundled together appear as activated but not in use. This report comes from my hardware driver info in Ubuntu Intrepid. Have tried to switch this one to be in use with no success. I am uncertain if I need all this stuff or should remove 2). As a linux newbie I am not familiar with compiling and merging software changes in existing drivers. Hope you can help. Best regards,
Detlef

Quoted 33 lines · Roberto Ragusa
Quoted 11 lines · Jochen Friedrich

Hi Roberto,

Quoted 3 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 8 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Hi Jochen,

thank you for your work. I see the table values are gone and parameters are computed by the code.

I will only be able to test this driver in a couple of days, as I do not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.

Do you prefer me to apply the patch to one tree in particular?

Signature · 11 lines
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY


_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#7 lore raw
In reply to Roberto Ragusa

Hi Roberto,

Quoted 2 lines

I will only be able to test this driver in a couple of days, as I do not have the hardware (Cinergy T USB XE Ver.2) with me at the moment.

No problem. I'm on holidays for the next two weeks as well.

Quoted 1 line

Do you prefer me to apply the patch to one tree in particular?

Not really. The patches are against 2.6.28-rc9.

Thanks,
Jochen

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#8 lore raw

Re: [linux-dvb] MC44S803 frontend (it works)

In reply to Jochen Friedrich

(to both linux-dvb and linux-media)

Quoted 10 lines · Jochen Friedrich

Hi Roberto,

Quoted 2 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 7 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Finally managed to try your version. It works, with no apparent issue.

Scanning is OK, tuning is OK.
I can't test signals below 600MHz at the moment, but I will try (possibly VHF too) in a couple of days, just to be sure about the frequency handling code. Also tried removing the USB stick while playing a stream; the devices were correctly removed when the user space apps closed them.

In my (user) opinion this driver is ready to be merged.

I actually fixed some trivial compilation issues in the driver.

linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100 renamed from linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 12:38:11.000000000 +0100 +4 -4
@@ -470,12 +470,12 @@
 
        mc44s80x_set_power(state, 0); /* disable powerdown */
        printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg1, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Write error\n");
                goto exit;
        }
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg2, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
                       TUNER_ADDR + 1);
@@ -495,7 +495,7 @@
        return 0;
 unk:
        printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
-              "(0x%02x)\n", __func__, id);
+              "(0x%02x)\n", id);
        goto out;
 exit:
        if (fe->ops.i2c_gate_ctrl)
@@ -512,7 +512,7 @@
        int err = 0;
 
        printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
-       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
+       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
        if (state == NULL) {
                err = -ENOMEM;
                goto exit;
Quoted 2 lines

Thanks,
Jochen

Thanks to you.

Signature · 6 lines
   Roberto Ragusa    mail at robertoragusa.it

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#9 lore raw

Re: [linux-dvb] MC44S803 frontend (it works)

Hi Roberto,
tnx for doing your test! As a Linux-newbie I better wait now until I can use a merged driver since I had bad experiences with former trys i.e. OS-crashes. Hopefully one Jochen or somebody else can soon do the rest. Meanwhile I am experimenting with a WXP-Pro VM running on my Ubuntu Intrepid Installation. Will try the native Terratec-SW on this machine. Best regards,
Detlef

Quoted 80 lines · Roberto Ragusa

(to both linux-dvb and linux-media)

Quoted 11 lines · Jochen Friedrich

Hi Roberto,

Quoted 3 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 8 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Finally managed to try your version. It works, with no apparent issue.

Scanning is OK, tuning is OK.
I can't test signals below 600MHz at the moment, but I will try (possibly VHF too) in a couple of days, just to be sure about the frequency handling code. Also tried removing the USB stick while playing a stream; the devices were correctly removed when the user space apps closed them.

In my (user) opinion this driver is ready to be merged.

I actually fixed some trivial compilation issues in the driver.

linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100 renamed from linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 12:38:11.000000000 +0100 +4 -4
@@ -470,12 +470,12 @@
 
        mc44s80x_set_power(state, 0); /* disable powerdown */
        printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg1, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Write error\n");
                goto exit;
        }
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg2, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
                       TUNER_ADDR + 1);
@@ -495,7 +495,7 @@
        return 0;
 unk:
        printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
-              "(0x%02x)\n", __func__, id);
+              "(0x%02x)\n", id);
        goto out;
 exit:
        if (fe->ops.i2c_gate_ctrl)
@@ -512,7 +512,7 @@
        int err = 0;
 
        printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
-       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
+       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
        if (state == NULL) {
                err = -ENOMEM;
                goto exit;
Quoted 5 lines

Thanks,
Jochen

Thanks to you.

Signature · 5 lines
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY
Quoted 80 lines · Roberto Ragusa

(to both linux-dvb and linux-media)

Quoted 11 lines · Jochen Friedrich

Hi Roberto,

Quoted 3 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

Quoted 8 lines

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Finally managed to try your version. It works, with no apparent issue.

Scanning is OK, tuning is OK.
I can't test signals below 600MHz at the moment, but I will try (possibly VHF too) in a couple of days, just to be sure about the frequency handling code. Also tried removing the USB stick while playing a stream; the devices were correctly removed when the user space apps closed them.

In my (user) opinion this driver is ready to be merged.

I actually fixed some trivial compilation issues in the driver.

linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100 renamed from linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 12:38:11.000000000 +0100 +4 -4
@@ -470,12 +470,12 @@
 
        mc44s80x_set_power(state, 0); /* disable powerdown */
        printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg1, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Write error\n");
                goto exit;
        }
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg2, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Read error, Reg=[0x%02x]\n",
                       TUNER_ADDR + 1);
@@ -495,7 +495,7 @@
        return 0;
 unk:
        printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
-              "(0x%02x)\n", __func__, id);
+              "(0x%02x)\n", id);
        goto out;
 exit:
        if (fe->ops.i2c_gate_ctrl)
@@ -512,7 +512,7 @@
        int err = 0;
 
        printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 0x%p\n", i2c);
-       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
+       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
        if (state == NULL) {
                err = -ENOMEM;
                goto exit;
Quoted 5 lines

Thanks,
Jochen

Thanks to you.

Signature · 11 lines
Dipl.-Ing. Detlef Rohde
Titiseestr. 12
D-13469 Berlin
Phone: +4930 4021731
A.R.S.: DL7IY


_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
#10 lore raw

Re: MC44S803 frontend (it works)

Hi again,
I wonder if there is any progress including/merging the frontend-driver MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently I can use it on a WXP-VM, but I guess it's not the best solution making this detour.. Regards
Detlef

Quoted 96 lines · Detlef Rohde

Hi Roberto,
tnx for doing your test! As a Linux-newbie I better wait now until I can use a merged driver since I had bad experiences with former trys i.e. OS-crashes. Hopefully one Jochen or somebody else can soon do the rest. Meanwhile I am experimenting with a WXP-Pro VM running on my Ubuntu Intrepid Installation. Will try the native Terratec-SW on this machine. Best regards,
Detlef

Quoted 88 lines · Roberto Ragusa

(to both linux-dvb and linux-media)

Quoted 14 lines · Jochen Friedrich

Hi Roberto,

Quoted 3 lines

Is there any plan to include this frontend in mainline kernels? I used to run this driver months ago and it was working well.

The reason is the huge memory footprint due to the included frequency table. I worked a bit on the driver to get rid of this table. Could you try this version:

1. Patch for AF9015:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=commitdiff;h=e5d7398a4b2d3c520d949e53bbf7667a481e9690

Quoted 9 lines

2. MC44S80x tuner driver:

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.c;h=b8dd335e64b03b8544b4c95e2d7f3dbd968078a0;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x.h;h=c6e76da6bf51163c90f0ead259c0e54d4f637671;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=blob;f=drivers/media/common/tuners/mc44s80x_reg.h;h=299c1be9a80a3777fb46f65d6070965de9754787;hb=4bde668b4eca90f8bdcc5916dfc88c115a3dfd20

Finally managed to try your version. It works, with no apparent issue.

Scanning is OK, tuning is OK.
I can't test signals below 600MHz at the moment, but I will try (possibly VHF too) in a couple of days, just to be sure about the frequency handling code. Also tried removing the USB stick while playing a stream; the devices were correctly removed when the user space apps closed them.

In my (user) opinion this driver is ready to be merged.

I actually fixed some trivial compilation issues in the driver.

--- a/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05
12:38:11.000000000 +0100
+++ b/linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100

linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100 renamed from linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 12:38:11.000000000 +0100 +2 -2
@@ -470,12 +470,12 @@
 
        mc44s80x_set_power(state, 0); /* disable powerdown */
        printk(KERN_WARNING "mc44s80x: MC44S80x get Device ID\n");
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg1, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Write error\n");
                goto exit;
        }
-       err = i2c_transfer(state->i2c, &msg, 1);
+       err = i2c_transfer(state->i2c, msg2, 1);
        if (err != 1) {
                printk(KERN_WARNING "mc44s80x: Read error, 
 Reg=[0x%02x]\n",
                       TUNER_ADDR + 1);
linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 16:12:59.000000000 +0100 renamed from linux/drivers/media/common/tuners/mc44s80x.c 2009-01-05 12:38:11.000000000 +0100 +2 -2
@@ -495,7 +495,7 @@
        return 0;
 unk:
        printk(KERN_WARNING "mc44s80x: Chip with unknown Revision ID "
-              "(0x%02x)\n", __func__, id);
+              "(0x%02x)\n", id);
        goto out;
 exit:
        if (fe->ops.i2c_gate_ctrl)
@@ -512,7 +512,7 @@
        int err = 0;
 
        printk(KERN_WARNING "mc44s80x: Trying to attach to Bus @ 
 0x%p\n", i2c);
-       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL));
+       state = kzalloc(sizeof(struct mc44s80x_state), GFP_KERNEL);
        if (state == NULL) {
                err = -ENOMEM;
                goto exit;
Quoted 3 lines

Thanks,
Jochen

Thanks to you.

#11 lore raw

Re: [linux-dvb] MC44S803 frontend (it works, please merge)

Quoted 5 lines · Detlef Rohde

Hi again,
I wonder if there is any progress including/merging the frontend-driver MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently I can use it on a WXP-VM, but I guess it's not the best solution making this detour..

I'm even more impatient than you.

Why is it so difficult to merge a little and isolated piece of code which has been reported as both working and useful?

I don't know how many trees this code has to be propagated through, but I'm afraid it will be a long time before I see support for this hardware in a stock Fedora kernel. Maybe the hardware could be considered obsolete by then.

Isn't one of the expected advantages of the free software + public mailing lists + user testing + git repositories model to have a fast pace of development?

Waiting and hoping.

Signature · 1 line
   Roberto Ragusa    mail at robertoragusa.it
#12 lore raw

Re: MC44S803 frontend (it works)

In reply to Detlef Rohde

Hi Detlef,

Quoted 4 lines

I wonder if there is any progress including/merging the frontend-driver MC44S803 i.o. to get my Cinergy T USB XE running under Linux? Currently I can use it on a WXP-VM, but I guess it's not the best solution making this detour..

Work is going on to merge this driver. However, it takes some time and review cycles to make sure the driver meets the quality and code style as defined in Documentation/development-process/2.Process.

Of course you could also download my kernel snapshot from
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
and test the preliminary driver ;-)

Thanks,
Jochen

#13 lore raw

Re: MC44S803 frontend (it works)

Hi Detlef,

Quoted 3 lines

Of course you could also download my kernel snapshot from
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
and test the preliminary driver ;-)

Better use
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=3efdc3ee161cfb9268ee95cfd6d14a9f6bc8ae51

Sorry, the old version contained a type preventing the driver to compile.

Thanks,
Jochen

#14 lore raw

Re: MC44S803 frontend (it works)

Hi Jochen,
thanks for your work. It's a bit stupid to put so much effort in getting a 20 €-device running. Easier way is buying another one which is better supported. On the other hand I learned much abt Linux. Will try your snapshot within the next few days and report on it. Regards,
Detlef

Quoted 21 lines · Jochen Friedrich

Hi Detlef,

Quoted 4 lines

Of course you could also download my kernel snapshot from
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=8d0441385cc9cf327d069b7185d2a647d4c77150
and test the preliminary driver ;-)

Better use
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=snapshot;h=3efdc3ee161cfb9268ee95cfd6d14a9f6bc8ae51

Sorry, the old version contained a type preventing the driver to compile.

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#16 lore raw

Re: MC44S803 frontend (it works)

Hi Antti,
thanks for your work. I unpacked mc44s803-b7ac1c462be3 and tried to run "make install" as root since I wanted to update my kernel modules. This did not work. On the other hand running only "make" finished with some warnings but no errors. My kernel is 2.6.27-11-generic from Ubuntu 8.10. The system is up to date. These tries I performed on a newly installed Linux where I never tried running my DVB-T stick (TerraTec Electronic GmbH Cinergy T XE DVB-T Receiver, MKII) under Linux before. Have installed VMware on this machine and can use the stick without problems in a WXP-Pro VM. Can you please give an advice what I should do next? I wo'nt destroy my running system. Best regards,
Detlef

Quoted 7 lines · Antti Palosaari

Hello
I just pushed Jochen's MC44S803 driver to linuxtv.org devel tree. I did some changes to patch that adds this tuner to AF9015, because patch didn't applied and also some other changes. Hopefully it doesn't break functionality. Please test.

http://linuxtv.org/hg/~anttip/mc44s803/

regards
Antti

#17 lore raw

Re: MC44S803 frontend (it works)

Quoted 4 lines · Detlef Rohde

Hi Antti,
thanks for your work. I unpacked mc44s803-b7ac1c462be3 and tried to run "make install" as root since I wanted to update my kernel modules. This did not work. On the other hand running only "make" finished with some warnings but no errors. My kernel is 2.6.27-11-generic from Ubuntu 8.10. The system is up to date. These tries I performed on a newly installed Linux where I never tried running my DVB-T stick (TerraTec Electronic GmbH Cinergy T XE DVB-T Receiver, MKII) under Linux before. Have installed VMware on this machine and can use the stick without problems in a WXP-Pro VM. Can you please give an advice what I should do next? I wo'nt destroy my running system. Best regards,
Detlef

Tahnks,
I did some more changes, could you test again:
http://linuxtv.org/hg/~anttip/mc44s803/

Antti

Signature · 1 line
http://palosaari.fi/
#18 lore raw

Re: MC44S803 frontend (it works)

Hi Antti,

Quoted 1 line

I did some more changes, could you test again:

This version works OK for me :-). The old version also worked, but was very insensitive (i only received one transponder instead of 6, i guess this GPIO must switch on some RF-amplifyer or so).

Thanks,
Jochen

#19 lore raw

Re: MC44S803 frontend (it works)

Hi Jochen,

Quoted 2 lines · Jochen Friedrich

This version works OK for me :-). The old version also worked, but was very insensitive (i only received one transponder instead of 6, i guess this GPIO must switch on some RF-amplifyer or so).

Yes, you are correct. I also ensured that from TerraTec provided driver.

I moved af9015_i2c_xfer() things back as I now think those are enough general. If driver now works, and you are also happy for af9015 changes I did, af9015 changes are fine for me too. Could you look and make fast test all are ok?

PS.
If you want remote working then send AF15IRTBL.bin (or USB-sniff) to me. From file I can look correct IR-codes for your remote control and after those are set it is rather easy to add key bindings for button events. This same apply all AF9015 devices, I am happy to add remotes too.

regards
Antti

Signature · 1 line
http://palosaari.fi/