Skip to contentSkip to conversation

libata: blacklist NCQ on OCZ CORE 2 SSD (resend)

PATCH In review Lubomír Bulej 4 participants 5 messages Dec 22, 2008 – Dec 30, 2008 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata: blacklist NCQ on OCZ CORE 2 SSD (resend)

The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the drive advertises NCQ support with queue depth 1, it responds with all-zeroes FIS to NCQ commands which triggers ata error handling several times before the kernel decides to disable NCQ on the drive.

drivers/ata/libata-core.c +1 -0
index 5e2eb74..ba38eb8 100644
@@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "Maxtor 7V300F0",	"VA111630",	ATA_HORKAGE_NONCQ },
 	{ "ST380817AS",		"3.42",		ATA_HORKAGE_NONCQ },
 	{ "ST3160023AS",	"3.42",		ATA_HORKAGE_NONCQ },
+	{ "OCZ CORE_SSD",	"02.10104",	ATA_HORKAGE_NONCQ },
 
 	/* Seagate NCQ + FLUSH CACHE firmware bug */
 	{ "ST31500341AS",	"9JU138",	ATA_HORKAGE_NONCQ |
Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 6 lines · Lubomír Bulej

The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the drive advertises NCQ support with queue depth 1, it responds with all-zeroes FIS to NCQ commands which triggers ata error handling several times before the kernel decides to disable NCQ on the drive.

Please capitalize the leading s and add --- separator between description and the patch body.

Quoted 12 lines
drivers/ata/libata-core.c +1 -0
index 5e2eb74..ba38eb8 100644
@@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry
 ata_device_blacklist [] = {
     { "Maxtor 7V300F0",    "VA111630",    ATA_HORKAGE_NONCQ },
     { "ST380817AS",        "3.42",        ATA_HORKAGE_NONCQ },
     { "ST3160023AS",    "3.42",        ATA_HORKAGE_NONCQ },
+    { "OCZ CORE_SSD",    "02.10104",    ATA_HORKAGE_NONCQ },
 
     /* Seagate NCQ + FLUSH CACHE firmware bug */
Quoted 1 line
     { "ST31500341AS",    "9JU138",    ATA_HORKAGE_NONCQ |

Other than that,

Signature · 1 line
tejun
#2 lore raw

Hello.

Quoted 11 lines · Tejun Heo
Quoted 7 lines

The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the drive advertises NCQ support with queue depth 1, it responds with all-zeroes FIS to NCQ commands which triggers ata error handling several times before the kernel decides to disable NCQ on the drive.

Please capitalize the leading s and add --- separator between description and the patch body.

Why Lubomir needs to add --- if there's no diffstat or comments? :-O

MBR, Sergei

#3 lore raw
Quoted 9 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Tejun Heo
Quoted 5 lines

The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the drive advertises NCQ support with queue depth 1, it responds with all-zeroes FIS to NCQ commands which triggers ata error handling several times before the kernel decides to disable NCQ on the drive.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Please capitalize the leading s and add --- separator between description and the patch body.

Why Lubomir needs to add --- if there's no diffstat or comments? :-

Hmm... now come to think of it, you're right. I guess I'm now just too accustomed to seeing it.

Thanks.

Signature · 1 line
tejun
#4 lore raw
In reply to Lubomír Bulej
Quoted 12 lines · Lubomír Bulej

The patchlet below blacklists NCQ on OCZ CORE v2 SSD drive(s). Even though the drive advertises NCQ support with queue depth 1, it responds with all-zeroes FIS to NCQ commands which triggers ata error handling several times before the kernel decides to disable NCQ on the drive.

drivers/ata/libata-core.c +0 -0
index 5e2eb74..ba38eb8 100644

drivers/ata/libata-core.c static const struct ata_blacklist_entry · line 4052

Quoted 5 lines
drivers/ata/libata-core.c +1 -0
@@ -4048,6 +4048,7 @@ static const struct ata_blacklist_entry 
 ata_device_blacklist [] = {
     { "Maxtor 7V300F0",    "VA111630",    ATA_HORKAGE_NONCQ },
     { "ST380817AS",        "3.42",        ATA_HORKAGE_NONCQ },
     { "ST3160023AS",    "3.42",        ATA_HORKAGE_NONCQ },
+    { "OCZ CORE_SSD",    "02.10104",    ATA_HORKAGE_NONCQ },

applied (manually)