Skip to contentSkip to conversation

arch: mips: Update initrd_start and initrd_end

PATCH New Horatiu Vultur 2 participants 2 messages Apr 24, 2019 – Apr 29, 2019 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch: mips: Update initrd_start and initrd_end

Microsemi SoC defines CONFIG_SYS_SDRAM_BASE to be 0x80000000, which represents the start of kseg0 and represents a virtual address. Meaning that the initrd_start and initrd_end point somewhere kseg0. When these parameters are passed to linux kernel through DT they are pointing somewhere in kseg0 which is a virtual address but linux kernel expects the addresses to be physical addresses(in kuseg) because it is converting the physical address to a virtual one.

Therefore update the uboot to pass the physical address of initrd_start and initrd_end by converting them using the function virt_to_phys before setting up the DT.

---
 arch/mips/lib/bootm.c | 2 ++
 1 file changed, 2 insertions(+)
arch/mips/lib/bootm.c +2 -0
index 35152cb..6a462f3 100644
@@ -247,6 +247,8 @@ int arch_fixup_fdt(void *blob)
 
 static int boot_setup_fdt(bootm_headers_t *images)
 {
+	images->initrd_start = virt_to_phys((void *)images->initrd_start);
+	images->initrd_end = virt_to_phys((void *)images->initrd_end);
 	return image_setup_libfdt(images, images->ft_addr, images->ft_len,
 		&images->lmb);
 }
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 arch: mips: Update initrd_start and initrd_end

Am 24.04.19 um 17:21 schrieb Horatiu Vultur:

Quoted 8 lines

Microsemi SoC defines CONFIG_SYS_SDRAM_BASE to be 0x80000000, which represents the start of kseg0 and represents a virtual address. Meaning that the initrd_start and initrd_end point somewhere kseg0. When these parameters are passed to linux kernel through DT they are pointing somewhere in kseg0 which is a virtual address but linux kernel expects the addresses to be physical addresses(in kuseg) because it is converting the physical address to a virtual one.

Quoted 8 lines

Therefore update the uboot to pass the physical address of initrd_start and initrd_end by converting them using the function virt_to_phys before setting up the DT.

---
 arch/mips/lib/bootm.c | 2 ++
 1 file changed, 2 insertions(+)

There is still a task on my TODO list to convert and interpret CONFIG_SYS_SDRAM_BASE as physical address on MIPS so that patch would actually not be necessary. Paul already prepared some patches in the past, but additionally we need to properly support map_physmem() and fix some places in common code. Until we have this, I'll apply this patch, thanks.

Quoted 15 lines
arch/mips/lib/bootm.c +2 -0
index 35152cb..6a462f3 100644
@@ -247,6 +247,8 @@ int arch_fixup_fdt(void *blob)
 
 static int boot_setup_fdt(bootm_headers_t *images)
 {
+	images->initrd_start = virt_to_phys((void *)images->initrd_start);
+	images->initrd_end = virt_to_phys((void *)images->initrd_end);
 	return image_setup_libfdt(images, images->ft_addr, images->ft_len,
 		&images->lmb);
 }
Signature · 1 line
- Daniel