Skip to contentSkip to conversation

ath5k: Correct usage of AR5K_CFG_ADHOC

PATCH In review Steve Brown 2 participants 2 messages Dec 23, 2008 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ath5k: Correct usage of AR5K_CFG_ADHOC

This corrects usage of AR5K_CFG_ADHOC introduced in 731818f956854fa3866f14107867969cf6e9b0cb (Update PCU code). Also, the name of the indicator is changed to AR5K_CFG_IBSS to more
accurately reflect its function. This change restores beaconing in AP and mesh modes.

---

Nick,

Is this what you had in mind?

Steve

drivers/net/wireless/ath5k/pcu.c +0 -0
index 0cac05c..b6e27a9 100644
@@ -65,7 +65,7 @@ int ath5k_hw_set_opmode(struct ath5k_hw *ah)
		if (ah->ah_version == AR5K_AR5210)
			pcu_reg |= AR5K_STA_ID1_NO_PSPOLL;
		else
-			AR5K_REG_DISABLE_BITS(ah, AR5K_CFG, AR5K_CFG_ADHOC);
+			AR5K_REG_ENABLE_BITS(ah, AR5K_CFG, AR5K_CFG_IBSS);
		break;

	case NL80211_IFTYPE_AP:
@@ -75,7 +75,7 @@ int ath5k_hw_set_opmode(struct ath5k_hw *ah)
		if (ah->ah_version == AR5K_AR5210)
			pcu_reg |= AR5K_STA_ID1_NO_PSPOLL;
		else
-			AR5K_REG_ENABLE_BITS(ah, AR5K_CFG, AR5K_CFG_ADHOC);
+			AR5K_REG_DISABLE_BITS(ah, AR5K_CFG, AR5K_CFG_IBSS);
		break;

	case NL80211_IFTYPE_STATION:
drivers/net/wireless/ath5k/reg.h +0 -0
index 91aaeaf..b709ad1 100644
@@ -73,7 +73,7 @@

#define AR5K_CFG_SWRD 0x00000004 /* Byte-swap RX descriptor */
#define AR5K_CFG_SWRB 0x00000008 /* Byte-swap RX buffer */
#define AR5K_CFG_SWRG 0x00000010 /* Byte-swap Register access */
-#define AR5K_CFG_ADHOC 0x00000020 /* AP/Adhoc indication [5211+] */
+#define AR5K_CFG_IBSS 0x00000020 /* 0-BSS, 1-IBSS [5211+] */
#define AR5K_CFG_PHY_OK 0x00000100 /* [5211+] */
#define AR5K_CFG_EEBS 0x00000200 /* EEPROM is busy */
#define AR5K_CFG_CLKGD 0x00000400 /* Clock gated (Disable dynamic clock) */

#1 lore raw

2008/12/23 Steve Brown <[email protected]>:

Quoted 51 lines

This corrects usage of AR5K_CFG_ADHOC introduced in 731818f956854fa3866f14107867969cf6e9b0cb (Update PCU code). Also, the name of the indicator is changed to AR5K_CFG_IBSS to more accurately reflect its function. This change restores beaconing in AP and mesh modes.

---

Nick,

Is this what you had in mind?

Steve

drivers/net/wireless/ath5k/pcu.c +2 -2
index 0cac05c..b6e27a9 100644
@@ -65,7 +65,7 @@ int ath5k_hw_set_opmode(struct ath5k_hw *ah)
               if (ah->ah_version == AR5K_AR5210)
                       pcu_reg |= AR5K_STA_ID1_NO_PSPOLL;
               else
-                       AR5K_REG_DISABLE_BITS(ah, AR5K_CFG, AR5K_CFG_ADHOC);
+                       AR5K_REG_ENABLE_BITS(ah, AR5K_CFG, AR5K_CFG_IBSS);
               break;
 
       case NL80211_IFTYPE_AP:
@@ -75,7 +75,7 @@ int ath5k_hw_set_opmode(struct ath5k_hw *ah)
               if (ah->ah_version == AR5K_AR5210)
                       pcu_reg |= AR5K_STA_ID1_NO_PSPOLL;
               else
-                       AR5K_REG_ENABLE_BITS(ah, AR5K_CFG, AR5K_CFG_ADHOC);
+                       AR5K_REG_DISABLE_BITS(ah, AR5K_CFG, AR5K_CFG_IBSS);
               break;
 
       case NL80211_IFTYPE_STATION:
drivers/net/wireless/ath5k/reg.h +0 -1
index 91aaeaf..b709ad1 100644
@@ -73,7 +73,7 @@
 #define AR5K_CFG_SWRD           0x00000004      /* Byte-swap RX descriptor
 */
 #define AR5K_CFG_SWRB           0x00000008      /* Byte-swap RX buffer */
 #define AR5K_CFG_SWRG           0x00000010      /* Byte-swap Register access
 */
-#define AR5K_CFG_ADHOC         0x00000020      /* AP/Adhoc indication

[5211+] */

Quoted 7 lines
+#define AR5K_CFG_IBSS          0x00000020      /* 0-BSS, 1-IBSS [5211+] */
#define AR5K_CFG_PHY_OK         0x00000100      /* [5211+] */
#define AR5K_CFG_EEBS           0x00000200      /* EEPROM is busy */
#define AR5K_CFG_CLKGD          0x00000400      /* Clock gated (Disable

dynamic clock) */

Yup ;-)

Thanks a lot !

Signature · 3 lines
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick