Skip to contentSkip to conversation

b43: Change schedule for old-fw support removal

PATCH In review Michael Buesch 2 participants 2 messages Dec 27, 2008

Subsystems (2)
Documentation Networking drivers (wireless)
lore
Share & tools
lore

Michael Buesch

author
#0 lore raw

PATCH 1/1 b43: Change schedule for old-fw support removal

The scheduled date for the removal of old fw support was in July 2008. However, we're not going to remove the support unless it causes a major headache. So change the schedule from "July 2008" to "when it causes headaches".

Signed-off-by Michael Buesch <[email protected]>

---

Please queue for 2.6.29

Documentation/feature-removal-schedule.txt +3 -1
Index: wireless-testing/Documentation/feature-removal-schedule.txt
===================================================================
@@ -233,13 +233,15 @@ When:	January 2009 or Linux 2.7.0, which
 Why:	Superseded by newer revisions or modules
 Who:	Jan Engelhardt <[email protected]>
 
 ---------------------------
 
 What:	b43 support for firmware revision < 410
-When:	July 2008
+When:	The schedule was July 2008, but it was decided that we are going to keep the
+        code as long as there are no major maintanance headaches.
+	So it _could_ be removed _any_ time now, if it conflicts with something new.
 Why:	The support code for the old firmware hurts code readability/maintainability
 	and slightly hurts runtime performance. Bugfixes for the old firmware
 	are not provided by Broadcom anymore.
 Who:	Michael Buesch <[email protected]>
 
 ---------------------------
drivers/net/wireless/b43/main.c +7 -3
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
@@ -1949,14 +1949,15 @@ static void b43_release_firmware(struct 
 
 static void b43_print_fw_helptext(struct b43_wl *wl, bool error)
 {
 	const char *text;
 
 	text = "You must go to "
-	       "http://linuxwireless.org/en/users/Drivers/b43#devicefirmware "
-	       "and download the latest firmware (version 4).\n";
+	       "http://wireless.kernel.org/en/users/Drivers/b43#devicefirmware "
+	       "and download the correct firmware for this driver version. "
+	       "Please carefully read all instructions on this website.\n";
 	if (error)
 		b43err(wl, text);
 	else
 		b43warn(wl, text);
 }
 

@@ -2266,14 +2267,17 @@ static int b43_upload_microcode(struct b
 				"Hardware accelerated cryptography is disabled.\n");
 			b43_print_fw_helptext(dev->wl, 0);
 		}
 	}
 
 	if (b43_is_old_txhdr_format(dev)) {
+		/* We're over the deadline, but we keep support for old fw
+		 * until it turns out to be in major conflict with something new. */
 		b43warn(dev->wl, "You are using an old firmware image. "
-			"Support for old firmware will be removed in July 2008.\n");
+			"Support for old firmware will be removed soon "
+			"(official deadline was July 2008).\n");
 		b43_print_fw_helptext(dev->wl, 0);
 	}
 
 	return 0;
 
 error:
Signature · 1 line
Greetings, Michael.
#1 lore raw
Quoted 5 lines · Michael Buesch

The scheduled date for the removal of old fw support was in July 2008. However, we're not going to remove the support unless it causes a major headache. So change the schedule from "July 2008" to "when it causes headaches".

Signed-off-by Michael Buesch <[email protected]>

ACK.

Larry