Skip to contentSkip to conversation

x86: amd_iommu_init.c iommu_enable and iommu_enable_event_logging should be static

PATCH Applied Jaswinder Singh Rajput 2 participants 2 messages Dec 29, 2008 – Dec 30, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: amd_iommu_init.c iommu_enable and iommu_enable_event_logging should be static

Impact: cleanup, reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
arch/x86/kernel/amd_iommu_init.c:246:13: warning: symbol 'iommu_enable' was not declared. Should it be static? arch/x86/kernel/amd_iommu_init.c:259:13: warning: symbol 'iommu_enable_event_logging' was not declared. Should it be static?

---
 arch/x86/kernel/amd_iommu_init.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/amd_iommu_init.c +2 -2
index c625800..fb85e8d 100644
@@ -243,7 +243,7 @@ static void __init iommu_feature_disable(struct amd_iommu *iommu, u8 bit)
 }
 
 /* Function to enable the hardware */
-void __init iommu_enable(struct amd_iommu *iommu)
+static void __init iommu_enable(struct amd_iommu *iommu)
 {
 	printk(KERN_INFO "AMD IOMMU: Enabling IOMMU "
 	       "at %02x:%02x.%x cap 0x%hx\n",
@@ -256,7 +256,7 @@ void __init iommu_enable(struct amd_iommu *iommu)
 }
 
 /* Function to enable IOMMU event logging and event interrupts */
-void __init iommu_enable_event_logging(struct amd_iommu *iommu)
+static void __init iommu_enable_event_logging(struct amd_iommu *iommu)
 {
 	iommu_feature_enable(iommu, CONTROL_EVT_LOG_EN);
 	iommu_feature_enable(iommu, CONTROL_EVT_INT_EN);
Signature · 1 line
1.5.5.1
#1 lore raw

Applied to tip:x86/cleanups:

Jaswinder Singh Rajput (4):
x86: amd_iommu_init.c: iommu_enable and iommu_enable_event_logging
should be static
x86: amd_iommu.c: prealloc_protection_domains should be static
x86: genx2apic_phys.c: x2apic_send_IPI_self and init_x2apic_ldr
should be static
x86: bios_uv.c: uv_systab should be static

Thanks!

-hpa