Skip to contentSkip to conversation

devtools: forbid experimental build flag for non-examples

PATCH In review David Marchand 2 participants 2 messages Jul 16, 2020 – Jul 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtools: forbid experimental build flag for non-examples

-DALLOW_EXPERIMENTAL_API is always set for in-tree compilation since
https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5

Warn people not to copy/paste this flag that was needed before.

---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
devtools/checkpatches.sh +8 -0
index 58021aa5dd..82d57b565b 100755
@@ -77,6 +77,14 @@ check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# forbid use of experimental build flag unneeded in non-examples
+	awk -v FOLDERS='app lib drivers' \
+		-v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using experimental build flag for in-tree compilation' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# svg figures must be included with wildcard extension
 	# because of png conversion for pdf docs
 	awk -v FOLDERS='doc' \
Signature · 1 line
2.23.0