Skip to contentSkip to conversation

usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28

PATCH In review Jiří Burda 4 participants 6 messages Jan 13, 2009 – Jan 15, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28

From: Jiri Burda <[email protected]>

Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous. This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832. This bug is recorded in kernel bugzilla as 12367.

---

drivers/usb/storage/unusual_devs.h renamed from drivers/usb/storage/unusual_devs.h.orig +1 -1
@@ -182,7 +182,7 @@ UNUSUAL_DEV(  0x0421, 0x0063, 0x0001, 0x
 		US_FL_FIX_CAPACITY ),
 
 /* Patch for Nokia 5310 capacity */
-UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0701,
+UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0832,
 		"Nokia",
 		"5310",
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
#1 lore raw
Quoted 11 lines · On Tue, 13 Jan 2009 18:36:20 +0100 Ji____ Burda <[email protected]> wrote:

From: Jiri Burda <[email protected]>

Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous. This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832. This bug is recorded in kernel bugzilla as 12367.

---

drivers/usb/storage/unusual_devs.h UNUSUAL_DEV( 0x0421, 0x0063, 0x0001, 0x · line 188

Quoted 8 lines
drivers/usb/storage/unusual_devs.h renamed from drivers/usb/storage/unusual_devs.h.orig +1 -1
@@ -182,7 +182,7 @@ UNUSUAL_DEV(  0x0421, 0x0063, 0x0001, 0x
 		US_FL_FIX_CAPACITY ),
 
 /* Patch for Nokia 5310 capacity */
-UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0701,
+UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0832,
 		"Nokia",
 		"5310",
 		US_SC_DEVICE, US_PR_DEVICE, NULL,

akpm:/usr/src/25> grep 5310 drivers/usb/storage/unusual_devs.h akpm:/usr/src/25>

The 5310 entry seems to have been removed in 2.6.29-rc1.

#2 lore raw
Quoted 26 lines · Andrew Morton
Quoted 11 lines · On Tue, 13 Jan 2009 18:36:20 +0100 Ji____ Burda <[email protected]> wrote:

From: Jiri Burda <[email protected]>

Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous. This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832. This bug is recorded in kernel bugzilla as 12367.

---

drivers/usb/storage/unusual_devs.h UNUSUAL_DEV( 0x0421, 0x0063, 0x0001, 0x · line 188

Quoted 8 lines
drivers/usb/storage/unusual_devs.h renamed from drivers/usb/storage/unusual_devs.h.orig +1 -1
@@ -182,7 +182,7 @@ UNUSUAL_DEV(  0x0421, 0x0063, 0x0001, 0x
 		US_FL_FIX_CAPACITY ),
 
 /* Patch for Nokia 5310 capacity */
-UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0701,
+UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0832,
 		"Nokia",
 		"5310",
 		US_SC_DEVICE, US_PR_DEVICE, NULL,

akpm:/usr/src/25> grep 5310 drivers/usb/storage/unusual_devs.h akpm:/usr/src/25>

Quoted 1 line

The 5310 entry seems to have been removed in 2.6.29-rc1.

Yes, we are handling all Nokia devices in a generic way now in 2.6.29, so patches like this should no longer be needed.

thanks,

greg k-h

maintainer
#3 lore raw
In reply to Andrew Morton
Quoted 7 lines · Andrew Morton
Quoted 5 lines

From: Jiri Burda <[email protected]>

Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous. This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832. This bug is recorded in kernel bugzilla as 12367.

The 5310 entry seems to have been removed in 2.6.29-rc1.

Indeed, as Greg mentioned we are now using a generic scheme for Nokia devices.

Jiri, can you try running 2.6.29-rc1 to see whether it's okay already?

Alan Stern

#4 lore raw

Alan,

I can confirm Nokia 5310 with firmware 8.32 mounts correctly in 2.6.29-rc1.

Jiri Burda

Alan Stern napsal(a):

Quoted 18 lines · Andrew Morton
Quoted 8 lines
Quoted 6 lines

From: Jiri Burda <[email protected]>

Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous. This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832. This bug is recorded in kernel bugzilla as 12367.

The 5310 entry seems to have been removed in 2.6.29-rc1.

Indeed, as Greg mentioned we are now using a generic scheme for Nokia devices.

Jiri, can you try running 2.6.29-rc1 to see whether it's okay already?

Alan Stern

maintainer
#5 lore raw
Quoted 3 lines · On Thu, 15 Jan 2009, [windows-1252] Jir(í Burda wrote:

Alan,

I can confirm Nokia 5310 with firmware 8.32 mounts correctly in 2.6.29-rc1.

Thanks for testing. So your patch will be needed only for 2.6.28.stable and earlier kernels.

Alan Stern