Skip to contentSkip to conversation

Allow SysRq emergency sync to thaw frozen filesystems

PATCH Bodo Eggert 2 participants 2 messages Jan 17, 2009 6 messages not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 10 lines · Eric Sandeen
Quoted 8 lines · [email protected] wrote:
Quoted 3 lines · Eric Sandeen

Oh, actually, I'd think not. If the freeze was done properly by the filesystem, all data was flushed, the fs was quiesced, and new IO was blocked. pdflush should never be visiting these...

Yes, but a lot of 'if's - and usually you're reaching for sysrq-S precisely *because* you suspect that stuff wasn't happening properly on its own...

Quoted 7 lines

Actually, only one if - if the fs implemented freeze properly.

Well, the use case I envision here is something like:

# freeze /my/mount/point/to/fs/to/snapshot

except oops, that wasn't mounted, and you just froze your root fs.

Maybe freeze should protect against that by requiring to specify the exact mountpount, unless you say freeze --subdir?

#7 lore raw
Quoted 11 lines · Bodo Eggert
Quoted 10 lines · Eric Sandeen
Quoted 7 lines · [email protected] wrote:
Quoted 3 lines · Eric Sandeen

Oh, actually, I'd think not. If the freeze was done properly by the filesystem, all data was flushed, the fs was quiesced, and new IO was blocked. pdflush should never be visiting these...

Yes, but a lot of 'if's - and usually you're reaching for sysrq-S precisely *because* you suspect that stuff wasn't happening properly on its own...

Actually, only one if - if the fs implemented freeze properly.

Quoted 8 lines
Quoted 5 lines

Well, the use case I envision here is something like:

# freeze /my/mount/point/to/fs/to/snapshot

except oops, that wasn't mounted, and you just froze your root fs.

Maybe freeze should protect against that by requiring to specify the exact mountpount, unless you say freeze --subdir?

That's a good idea. My "freeze" above was a hypothetical tool which doesn't really exist yet, but should get that enhancement. :) (xfs_freeze does not do this checking today, it probably should)

-Eric