via-velocity: fix hot spin

PATCH Applied Roel Kluin 2 participants 2 messages Jan 17, 2009 – Jan 18, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-01-17 21:14 UTC #0 lore raw

PATCH 1/1 via-velocity: fix hot spin

while(--j >= 0) keeps spinning when j is unsigned:

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/via-velocity.c +1 -1

index a75f91d..c5691fd 100644
@@ -1302,7 +1302,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
 static int velocity_init_td_ring(struct velocity_info *vptr)
 {
 	dma_addr_t curr;
-	unsigned int j;
+	int j;
 
 	/* Init the TD ring entries */
 	for (j = 0; j < vptr->tx.numq; j++) {

David Miller

maintainer Applied

2009-01-18 07:07 UTC #1 lore raw

From: Roel Kluin <[email protected]>
Date: Sat, 17 Jan 2009 22:14:31 +0100

Quoted 3 lines

while(--j >= 0) keeps spinning when j is unsigned:
Signed-off-by Roel Kluin <[email protected]>

Applied, thanks Roel.