DVB: negative internal->sub_range won't get noticed

PATCH New Roel Kluin 1 participant 1 message Jan 18, 2009 Media (V4L/DVB)

lore

Share & tools

lore

Roel Kluin

author

2009-01-18 23:31 UTC #0 lore raw

PATCH 1/1 DVB: negative internal->sub_range won't get noticed

internal->sub_range is unsigned, a negative won't get noticed.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/media/dvb/frontends/stb0899_algo.c +5 -4

index 83dc7e1..2ea32da 100644
@@ -464,13 +464,14 @@ static void next_sub_range(struct stb0899_state *state)
 
 	if (internal->sub_dir > 0) {
 		old_sub_range = internal->sub_range;
-		internal->sub_range = MIN((internal->srch_range / 2) -
+		if (internal->tuner_offst + internal->sub_range / 2 >=
+				internal->srch_range / 2)
+			internal->sub_range = 0;
+		else
+			internal->sub_range = MIN((internal->srch_range / 2) -
 					  (internal->tuner_offst + internal->sub_range / 2),
 					   internal->sub_range);
 
-		if (internal->sub_range < 0)
-			internal->sub_range = 0;
-
 		internal->tuner_offst += (old_sub_range + internal->sub_range) / 2;
 	}