Skip to contentSkip to conversation

drm: tidss: Fix pixel format definition

PATCH In review Randolph Sapp 4 participants 4 messages Dec 2, 2022 – Dec 16, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: tidss: Fix pixel format definition

There was a long-standing bug from a typo that created 2 ARGB1555 and ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted me to this issue.

According to the Supported Pixel Data formats table we have the later entries should have been for Alpha-X instead.

---
 drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tidss/tidss_dispc.c +2 -2
index ad93acc9abd2..16301bdfead1 100644
@@ -1858,8 +1858,8 @@ static const struct {
 	{ DRM_FORMAT_XBGR4444, 0x21, },
 	{ DRM_FORMAT_RGBX4444, 0x22, },
 
-	{ DRM_FORMAT_ARGB1555, 0x25, },
-	{ DRM_FORMAT_ABGR1555, 0x26, },
+	{ DRM_FORMAT_XRGB1555, 0x25, },
+	{ DRM_FORMAT_XBGR1555, 0x26, },
 
 	{ DRM_FORMAT_XRGB8888, 0x27, },
 	{ DRM_FORMAT_XBGR8888, 0x28, },
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Randolph Sapp

There was a long-standing bug from a typo that created 2 ARGB1555 and ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted me to this issue.

According to the Supported Pixel Data formats table we have the later entries should have been for Alpha-X instead.

Fixes 32a1795f57eecc

Quoted 20 lines
---
  drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tidss/tidss_dispc.c +2 -2
index ad93acc9abd2..16301bdfead1 100644
@@ -1858,8 +1858,8 @@ static const struct {
  	{ DRM_FORMAT_XBGR4444, 0x21, },
  	{ DRM_FORMAT_RGBX4444, 0x22, },
 
-	{ DRM_FORMAT_ARGB1555, 0x25, },
-	{ DRM_FORMAT_ABGR1555, 0x26, },
+	{ DRM_FORMAT_XRGB1555, 0x25, },
+	{ DRM_FORMAT_XBGR1555, 0x26, },
 
  	{ DRM_FORMAT_XRGB8888, 0x27, },
  	{ DRM_FORMAT_XBGR8888, 0x28, },
Reviewed-by
#2 lore raw
Quoted 5 lines · Andrew Davis
Quoted 4 lines · Randolph Sapp

There was a long-standing bug from a typo that created 2 ARGB1555 and ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted me to this issue.

Quoted 9 lines
Quoted 3 lines

According to the Supported Pixel Data formats table we have the later entries should have been for Alpha-X instead.

Fixes 32a1795f57eecc

Quoted 1 line
Quoted 17 lines
Quoted 17 lines

---
  drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tidss/tidss_dispc.c +2 -2
index ad93acc9abd2..16301bdfead1 100644
@@ -1858,8 +1858,8 @@ static const struct {
       { DRM_FORMAT_XBGR4444, 0x21, },
       { DRM_FORMAT_RGBX4444, 0x22, },
-    { DRM_FORMAT_ARGB1555, 0x25, },
-    { DRM_FORMAT_ABGR1555, 0x26, },
+    { DRM_FORMAT_XRGB1555, 0x25, },
+    { DRM_FORMAT_XBGR1555, 0x26, },
       { DRM_FORMAT_XRGB8888, 0x27, },
       { DRM_FORMAT_XBGR8888, 0x28, },
maintainer
#3 lore raw
In reply to Randolph Sapp
Quoted 17 lines · Randolph Sapp

There was a long-standing bug from a typo that created 2 ARGB1555 and ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted me to this issue.

According to the Supported Pixel Data formats table we have the later entries should have been for Alpha-X instead.

---
  drivers/gpu/drm/tidss/tidss_dispc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/tidss/tidss_dispc.c +0 -0
index ad93acc9abd2..16301bdfead1 100644

drivers/gpu/drm/tidss/tidss_dispc.c static const struct { · line 1865

Quoted 10 lines
drivers/gpu/drm/tidss/tidss_dispc.c +2 -2
@@ -1858,8 +1858,8 @@ static const struct {
  	{ DRM_FORMAT_XBGR4444, 0x21, },
  	{ DRM_FORMAT_RGBX4444, 0x22, },
 
-	{ DRM_FORMAT_ARGB1555, 0x25, },
-	{ DRM_FORMAT_ABGR1555, 0x26, },
+	{ DRM_FORMAT_XRGB1555, 0x25, },
+	{ DRM_FORMAT_XBGR1555, 0x26, },
 
  	{ DRM_FORMAT_XRGB8888, 0x27, },
  	{ DRM_FORMAT_XBGR8888, 0x28, },

Thanks, I'll apply to drm-misc.

Tomi