Skip to contentSkip to conversation

hda: Add STAC92HD83XXX_PWR_REF quirk

PATCH In review Matthew Ranostay 2 participants 4 messages Jan 21, 2009 – Jan 22, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda: Add STAC92HD83XXX_PWR_REF quirk

Some revisions of the 92hd8xxx codec's not supporting port power downs in which the using of it causes capture and also randomly playback streams to not function at all. Thus by disabling it by default and adding a option to enable it manually will fix all issue on current and future revisions.

Signed-by-off: Matthew Ranostay <[email protected]>
---

Documentation/sound/alsa/HD-Audio-Models.txt +1 -0
index 75914bc..2119175 100644
@@ -349,6 +349,7 @@ STAC92HD73*
 STAC92HD83*
 ===========
   ref		Reference board
+  mic-ref	Reference board with power managment for ports
 
 STAC9872
 ========
sound/pci/hda/patch_sigmatel.c +13 -8
index dbe8b12..a961c51 100644
@@ -81,6 +81,7 @@ enum {
 
 enum {
 	STAC_92HD83XXX_REF,
+	STAC_92HD83XXX_PWR_REF,
 	STAC_92HD83XXX_MODELS
 };
 
@@ -334,7 +335,7 @@ static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
 };
 
 static unsigned int stac92hd83xxx_pwr_mapping[4] = {
-	0x03, 0x0c, 0x20, 0x80,
+	0x03, 0x0c, 0x20, 0x40,
 };
 
 static hda_nid_t stac92hd83xxx_amp_nids[1] = {
@@ -1734,10 +1735,12 @@ static unsigned int ref92hd83xxx_pin_configs[14] = {
 
 static unsigned int *stac92hd83xxx_brd_tbl[STAC_92HD83XXX_MODELS] = {
 	[STAC_92HD83XXX_REF] = ref92hd83xxx_pin_configs,
+	[STAC_92HD83XXX_PWR_REF] = ref92hd83xxx_pin_configs,
 };
 
 static const char *stac92hd83xxx_models[STAC_92HD83XXX_MODELS] = {
 	[STAC_92HD83XXX_REF] = "ref",
+	[STAC_92HD83XXX_PWR_REF] = "mic-ref",
 };
 
 static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
@@ -4781,13 +4784,6 @@ static int patch_stac92hd83xxx(struct hda_codec *codec)
 		AC_VERB_SET_CONNECT_SEL, num_dacs);
 
 	spec->init = stac92hd83xxx_core_init;
-	switch (codec->vendor_id) {
-	case 0x111d7605:
-		break;
-	default:
-		spec->num_pwrs--;
-	}
-
 	spec->mixer = stac92hd83xxx_mixer;
 	spec->num_pins = ARRAY_SIZE(stac92hd83xxx_pin_nids);
 	spec->num_dmuxes = ARRAY_SIZE(stac92hd83xxx_dmux_nids);
@@ -4813,6 +4809,15 @@ again:
 		return err;
 	}
 
+	switch (codec->vendor_id) {
+	case 0x111d7604:
+	case 0x111d7605:
+		if (spec->board_config == STAC_92HD83XXX_PWR_REF)
+			break;
+		spec->num_pwrs = 0;
+		break;
+	}
+
 	err = stac92xx_parse_auto_config(codec, 0x1d, 0);
 	if (!err) {
 		if (spec->board_config < 0) {
#1 lore raw

At Wed, 21 Jan 2009 17:39:43 -0500,

sound/pci/hda/patch_sigmatel.c static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = { · line 339

Quoted 8 lines · Matthew Ranostay
sound/pci/hda/patch_sigmatel.c +1 -1
@@ -334,7 +335,7 @@ static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
 };
 
 static unsigned int stac92hd83xxx_pwr_mapping[4] = {
-	0x03, 0x0c, 0x20, 0x80,
+	0x03, 0x0c, 0x20, 0x40,
 };

What is this change?

thanks,

Takashi

#2 lore raw
Quoted 13 lines · Takashi Iwai

At Wed, 21 Jan 2009 17:39:43 -0500,

sound/pci/hda/patch_sigmatel.c static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = { · line 339

Quoted 7 lines · Matthew Ranostay
sound/pci/hda/patch_sigmatel.c +1 -1
@@ -334,7 +335,7 @@ static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
 };
 
 static unsigned int stac92hd83xxx_pwr_mapping[4] = {
-	0x03, 0x0c, 0x20, 0x80,
+	0x03, 0x0c, 0x20, 0x40,
 };

What is this change?

Quoted 1 line

From my patch before I made a mistake, somehow I thought port 0xe was 0xf in that

change. Sorry for the inconvenience.

Thanks,

Matt

Quoted 4 lines

thanks,

Takashi

#3 lore raw

At Thu, 22 Jan 2009 08:23:03 -0500,

Quoted 15 lines · Matthew Ranostay
Quoted 5 lines · Takashi Iwai

At Wed, 21 Jan 2009 17:39:43 -0500,

Quoted 3 lines · Matthew Ranostay
(quoted diff) +0 -0
@@ -334,7 +335,7 @@ static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
 };
 
Quoted 8 lines

sound/pci/hda/patch_sigmatel.c static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = { · line 339

Quoted 4 lines
sound/pci/hda/patch_sigmatel.c +1 -1
 static unsigned int stac92hd83xxx_pwr_mapping[4] = {
-	0x03, 0x0c, 0x20, 0x80,
+	0x03, 0x0c, 0x20, 0x40,
 };

What is this change?

Quoted 2 lines

From my patch before I made a mistake, somehow I thought port 0xe was 0xf in that change. Sorry for the inconvenience.

Well, if it's needed to be fixed, please create another patch, since this change is basically independent from PWR_REF quirk. Or, at least, include some proper description in changelog.

thanks,

Takashi