Skip to contentSkip to conversation

rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

PATCH In review Lai Jiangshan 4 participants 5 messages Jan 22, 2009 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

This patch remove the old one.

---

lib/Kconfig.debug +0 -13
index 4c9ae60..e770e85 100644
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
 	bool "Check for stalled CPUs delaying RCU grace periods"
-	depends on CLASSIC_RCU
-	default n
-	help
-	  This option causes RCU to printk information on which
-	  CPUs are delaying the current grace period, but only when
-	  the grace period extends for excessive time periods.
-
-	  Say Y if you want RCU to perform such checks.
-
-	  Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-	bool "Check for stalled CPUs delaying RCU grace periods"
 	depends on CLASSIC_RCU || TREE_RCU
 	default n
 	help
#1 lore raw
Quoted 10 lines · Lai Jiangshan

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

This patch remove the old one.

Good eyes!

However, Jiri Kosina has already queued this up for the trivial tree:

	http://lkml.org/lkml/2009/1/15/218

						Thanx, Paul
Quoted 28 lines

---

lib/Kconfig.debug +0 -13
index 4c9ae60..e770e85 100644
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
 	bool "Check for stalled CPUs delaying RCU grace periods"
-	depends on CLASSIC_RCU
-	default n
-	help
-	  This option causes RCU to printk information on which
-	  CPUs are delaying the current grace period, but only when
-	  the grace period extends for excessive time periods.
-
-	  Say Y if you want RCU to perform such checks.
-
-	  Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-	bool "Check for stalled CPUs delaying RCU grace periods"
 	depends on CLASSIC_RCU || TREE_RCU
 	default n
 	help
#2 lore raw
Quoted 10 lines · Paul E. McKenney
Quoted 9 lines · Lai Jiangshan

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

Quoted 7 lines
Quoted 1 line

This patch remove the old one.

Good eyes!

However, Jiri Kosina has already queued this up for the trivial tree:

	http://lkml.org/lkml/2009/1/15/218

i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig structure there.

Ingo

#3 lore raw
Quoted 15 lines · Ingo Molnar
Quoted 12 lines · Paul E. McKenney
Quoted 10 lines · Lai Jiangshan

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

This patch remove the old one.

Quoted 8 lines
Quoted 5 lines

Good eyes!

However, Jiri Kosina has already queued this up for the trivial tree:

	http://lkml.org/lkml/2009/1/15/218

i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig structure there.

Works for me!

Thanx, Paul

#4 lore raw
In reply to Ingo Molnar
Quoted 10 lines · Ingo Molnar
Quoted 10 lines
Quoted 9 lines

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

This patch remove the old one.

Quoted 8 lines
Quoted 5 lines

Good eyes!

However, Jiri Kosina has already queued this up for the trivial tree:

	http://lkml.org/lkml/2009/1/15/218

i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig structure there.

No problem, I have dropped that.

Signature · 2 lines
Jiri Kosina
SUSE Labs