Skip to contentSkip to conversation

xfs_io: fix comment in bmap.c

PATCH In review Christoph Hellwig 3 participants 3 messages Jan 24, 2009

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 xfs_io: fix comment in bmap.c

Based on a patch from Tomasz Majkowski <[email protected]> in bugzilla #785.

Signed-off-by Christoph Hellwig <[email protected]>
io/bmap.c +2 -2
Index: xfsprogs-dev/io/bmap.c
===================================================================
@@ -140,7 +140,7 @@ bmap_f(
 		}
 	}
 
-	map_size = nflag ? nflag+2 : 32;	/* initial guess - 256 */
+	map_size = nflag ? nflag+2 : 32;	/* initial guess - 32 */
 	map = malloc(map_size*sizeof(*map));
 	if (map == NULL) {
 		fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),

@@ -151,7 +151,7 @@ bmap_f(
 
 
 /*	Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents specified
- *	by nflag, or the initial guess number of extents (256).
+ *	by nflag, or the initial guess number of extents (32).
  *
  *	If there are more extents than we guessed, use xfsctl
  *	(XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 3 lines · Christoph Hellwig

Based on a patch from Tomasz Majkowski <[email protected]> in bugzilla #785.

Heh, I can ACK this one :)

-Eric

Quoted 25 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: xfsprogs-dev/io/bmap.c
===================================================================

io/bmap.c +2 -2
@@ -140,7 +140,7 @@ bmap_f(
 		}
 	}
 
-	map_size = nflag ? nflag+2 : 32;	/* initial guess - 256 */
+	map_size = nflag ? nflag+2 : 32;	/* initial guess - 32 */
 	map = malloc(map_size*sizeof(*map));
 	if (map == NULL) {
 		fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),

@@ -151,7 +151,7 @@ bmap_f(
 
 
 /*	Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents specified
- *	by nflag, or the initial guess number of extents (256).
+ *	by nflag, or the initial guess number of extents (32).
  *
  *	If there are more extents than we guessed, use xfsctl
  *	(XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

Based on a patch from Tomasz Majkowski <[email protected]> in bugzilla #785.

Easy one, make comments reflect the code.
Looks good.

Felix

Quoted 28 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: xfsprogs-dev/io/bmap.c
===================================================================

io/bmap.c +1 -1
@@ -140,7 +140,7 @@ bmap_f(
 		}
 	}
 
-	map_size = nflag ? nflag+2 : 32;	/* initial guess - 256 */
+	map_size = nflag ? nflag+2 : 32;	/* initial guess - 32 */
 	map = malloc(map_size*sizeof(*map));
 	if (map == NULL) {
 		fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),

@@ -151,7 +151,7 @@ bmap_f(
 
 
 /*	Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents

specified
- * by nflag, or the initial guess number of extents (256).
+ * by nflag, or the initial guess number of extents (32).
*
* If there are more extents than we guessed, use xfsctl
* (XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more

Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs