Skip to contentSkip to conversation

hda: 92hd71xxx disable unmute support for codecs that don't have input amps.

PATCH In review Matthew Ranostay 2 participants 3 messages Jan 24, 2009 – Jan 26, 2009 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda: 92hd71xxx disable unmute support for codecs that don't have input amps.

Some revisions of the 92hd71xxx codec families don't have input amps on ports 0xa, 0xd and 0xf, so probe the widget caps on port 0xa and check for support, if found run snd_hda_sequence_write() on the stac92hd71xxx_unmute_core_init verb list.

---
 sound/pci/hda/patch_sigmatel.c |   20 ++++++++++++--------
 1 files changed, 12 insertions(+), 8 deletions(-)
sound/pci/hda/patch_sigmatel.c +12 -8
index 80a4c28..ffef091 100644
@@ -858,26 +858,25 @@ static struct hda_verb stac92hd83xxx_core_init[] = {
 static struct hda_verb stac92hd71bxx_core_init[] = {
 	/* set master volume and direct control */
 	{ 0x28, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
-	/* unmute right and left channels for nodes 0x0a, 0xd, 0x0f */
-	{ 0x0a, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
-	{ 0x0d, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
-	{ 0x0f, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{}
 };
 
-#define HD_DISABLE_PORTF 2
+#define HD_DISABLE_PORTF 1
 static struct hda_verb stac92hd71bxx_analog_core_init[] = {
 	/* start of config #1 */
 
 	/* connect port 0f to audio mixer */
 	{ 0x0f, AC_VERB_SET_CONNECT_SEL, 0x2},
-	/* unmute right and left channels for node 0x0f */
-	{ 0x0f, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	/* start of config #2 */
 
 	/* set master volume and direct control */
 	{ 0x28, AC_VERB_SET_VOLUME_KNOB_CONTROL, 0xff},
-	/* unmute right and left channels for nodes 0x0a, 0xd */
+	{}
+};
+
+static struct hda_verb stac92hd71bxx_unmute_core_init[] = {
+	/* unmute right and left channels for nodes 0x0f, 0xa, 0x0d */
+	{ 0x0f, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{ 0x0a, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{ 0x0d, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_UNMUTE(0)},
 	{}
@@ -4942,6 +4941,7 @@ static struct hda_input_mux stac92hd71bxx_dmux = {
 static int patch_stac92hd71bxx(struct hda_codec *codec)
 {
 	struct sigmatel_spec *spec;
+	struct hda_verb *unmute_init = stac92hd71bxx_unmute_core_init;
 	int err = 0;
 
 	spec  = kzalloc(sizeof(*spec), GFP_KERNEL);
@@ -5015,6 +5015,7 @@ again:
 
 		/* disable VSW */
 		spec->init = &stac92hd71bxx_analog_core_init[HD_DISABLE_PORTF];
+		unmute_init++;
 		stac_change_pin_config(codec, 0xf, 0x40f000f0);
 		break;
 	case 0x111d7603: /* 6 Port with Analog Mixer */
@@ -5031,6 +5032,9 @@ again:
 		codec->slave_dig_outs = stac92hd71bxx_slave_dig_outs;
 	}
 
+	if (get_wcaps(codec, 0xa) & AC_WCAP_IN_AMP)
+		snd_hda_sequence_write(codec, unmute_init);
+
 	spec->aloopback_mask = 0x50;
 	spec->aloopback_shift = 0;
 
Signature · 1 line
1.5.6.3
#1 lore raw

At Sat, 24 Jan 2009 14:19:31 -0500,

sound/pci/hda/patch_sigmatel.c again: · line 5036

Quoted 7 lines · Matthew Ranostay
sound/pci/hda/patch_sigmatel.c +2 -0
@@ -5031,6 +5032,9 @@ again:
 		codec->slave_dig_outs = stac92hd71bxx_slave_dig_outs;
 	}
 
+	if (get_wcaps(codec, 0xa) & AC_WCAP_IN_AMP)
+		snd_hda_sequence_write(codec, unmute_init);

This sequence should be cached so that it'll be replayed at suspend/resume.

Could you fix and repost?

thanks,

Takashi

#2 lore raw
Quoted 6 lines · Takashi Iwai

At Sat, 24 Jan 2009 14:19:31 -0500,

Quoted 4 lines · Matthew Ranostay
sound/pci/hda/patch_sigmatel.c +0 -0
@@ -5031,6 +5032,9 @@ again:
 		codec->slave_dig_outs = stac92hd71bxx_slave_dig_outs;
 	}
 
Quoted 6 lines

sound/pci/hda/patch_sigmatel.c again: · line 5036

Quoted 2 lines
sound/pci/hda/patch_sigmatel.c +2 -0
+	if (get_wcaps(codec, 0xa) & AC_WCAP_IN_AMP)
+		snd_hda_sequence_write(codec, unmute_init);

This sequence should be cached so that it'll be replayed at suspend/resume.

Good catch, can't believe I missed that.

Quoted 2 lines

Could you fix and repost?

Yep.

Thanks,

Matt Ranostay

Quoted 5 lines

thanks,

Takashi