Skip to contentSkip to conversation

Fix misspelling of "firmware"

PATCH In review Nick Andrew 5 participants 29 messages Jan 26, 2009 – Jan 27, 2009

Subsystems (16)
lore
Share & tools
lore
#0 lore raw

cover Fix misspelling of "firmware"

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are comment changes.

Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c Fix misspelling of firmware in iwl3945-base.c Fix misspelling of firmware in hpmain.c Fix misspelling of firmware in head_64.S Fix misspelling of firmware in aica.c Fix misspelling of firmware in pss.c Fix misspelling of firmware in disk.c Fix misspelling of firmware in libata.h Fix misspelling of firmware in ChangeLog.history Fix misspelling of firmware in ueagle-atm.c Fix misspelling of firmware in pci.c Fix misspelling of firmware in cmd.c Fix misspelling of firmware in ipw2200.c Fix misspelling of firmware in ipw2100.c Fix misspelling of firmware in tg3.c Fix misspelling of firmware in sb1250-mac.c Fix misspelling of firmware in thinkpad_acpi.c Fix misspelling of "firmware" in ip27-smp.c Fix misspelling of "firmware" in firmware.txt Fix misspelling of "firmware" in ia64-kvm.txt

 Documentation/ia64/kvm.txt                         |    2 +-
 .../dts-bindings/fsl/cpm_qe/qe/firmware.txt        |    2 +-
 arch/mips/sgi-ip27/ip27-smp.c                      |    2 +-
 arch/sparc/kernel/head_64.S                        |    2 +-
 drivers/net/sb1250-mac.c                           |    2 +-
 drivers/net/tg3.c                                  |    2 +-
 drivers/net/wireless/ipw2x00/ipw2100.c             |    2 +-
 drivers/net/wireless/ipw2x00/ipw2200.c             |    2 +-
 drivers/net/wireless/iwlwifi/iwl-agn.c             |    2 +-
 drivers/net/wireless/iwlwifi/iwl3945-base.c        |    2 +-
 drivers/net/wireless/libertas/cmd.c                |    2 +-
 drivers/pci/pci.c                                  |    2 +-
 drivers/platform/x86/thinkpad_acpi.c               |    2 +-
 drivers/staging/otus/hal/hpmain.c                  |    2 +-
 drivers/usb/atm/ueagle-atm.c                       |    2 +-
 drivers/usb/serial/ChangeLog.history               |    2 +-
 include/linux/libata.h                             |    2 +-
 kernel/power/disk.c                                |    4 ++--
 sound/oss/pss.c                                    |    2 +-
 sound/sh/aica.c                                    |    2 +-
 20 files changed, 21 insertions(+), 21 deletions(-)
Signature · 2 lines
PGP Key ID = 0x418487E7                      http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A  67E3 6266 6EB9 4184 87E7
#1 lore raw

PATCH 1/20 Fix misspelling of "firmware" in ia64-kvm.txt

Fix misspelling of "firmware" in ia64-kvm.txt

---

 Documentation/ia64/kvm.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/ia64/kvm.txt +1 -1
index 84f7cb3..ffb5c80 100644
@@ -42,7 +42,7 @@ Note: For step 2, please make sure that host page size == TARGET_PAGE_SIZE of qe
 		hg clone http://xenbits.xensource.com/ext/efi-vfirmware.hg
 	    you can get the firmware's binary in the directory of efi-vfirmware.hg/binaries.
 
-	(3) Rename the firware you owned to Flash.fd, and copy it to /usr/local/share/qemu
+	(3) Rename the firmware you owned to Flash.fd, and copy it to /usr/local/share/qemu
 
 4. Boot up Linux or Windows guests:
 	4.1 Create or install a image for guest boot. If you have xen experience, it should be easy.
#2 lore raw

PATCH 2/20 Fix misspelling of "firmware" in firmware.txt

In reply to Nick Andrew

Fix misspelling of "firmware" in firmware.txt

---

 .../dts-bindings/fsl/cpm_qe/qe/firmware.txt        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/powerpc/dts-bindings/fsl/cpm_qe/qe/firmware.txt +1 -1
index 6c238f5..249db3a 100644
@@ -1,6 +1,6 @@
 * Uploaded QE firmware
 
-      If a new firwmare has been uploaded to the QE (usually by the
+      If a new firmware has been uploaded to the QE (usually by the
       boot loader), then a 'firmware' child node should be added to the QE
       node.  This node provides information on the uploaded firmware that
       device drivers may need.
#3 lore raw

PATCH 3/20 Fix misspelling of "firmware" in ip27-smp.c

In reply to Nick Andrew

Fix misspelling of "firmware" in ip27-smp.c

---

 arch/mips/sgi-ip27/ip27-smp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/sgi-ip27/ip27-smp.c +1 -1
index 5b47d6b..cbcd7eb 100644
@@ -221,7 +221,7 @@ static void __init ip27_smp_setup(void)
 	 * Assumption to be fixed: we're always booted on logical / physical
 	 * processor 0.  While we're always running on logical processor 0
 	 * this still means this is physical processor zero; it might for
-	 * example be disabled in the firwware.
+	 * example be disabled in the firmware.
 	 */
 	alloc_cpupda(0, 0);
 }
#4 lore raw

PATCH 4/20 Fix misspelling of firmware in thinkpad_acpi.c

In reply to Nick Andrew

Fix misspelling of firmware in thinkpad_acpi.c

---

 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +1 -1
index bcbc051..54e0cbc 100644
@@ -5811,7 +5811,7 @@ static struct ibm_struct volume_driver_data = {
  *	ThinkPads from this same time period (and earlier) probably lack the
  *	tachometer as well.
  *
- *	Unfortunately a lot of ThinkPads with new-style ECs but whose firwmare
+ *	Unfortunately a lot of ThinkPads with new-style ECs but whose firmware
  *	was never fixed by IBM to report the EC firmware version string
  *	probably support the tachometer (like the early X models), so
  *	detecting it is quite hard.  We need more data to know for sure.
#5 lore raw

PATCH 5/20 Fix misspelling of firmware in sb1250-mac.c

In reply to Nick Andrew

Fix misspelling of firmware in sb1250-mac.c

---

 drivers/net/sb1250-mac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/sb1250-mac.c +1 -1
index 31e38fa..7fe82c5 100644
@@ -2299,7 +2299,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)
 	eaddr = sc->sbm_hwaddr;
 
 	/*
-	 * Read the ethernet address.  The firwmare left this programmed
+	 * Read the ethernet address.  The firmware left this programmed
 	 * for us in the ethernet address register for each mac.
 	 */
 
#6 lore raw

PATCH 6/20 Fix misspelling of firmware in tg3.c

In reply to Nick Andrew

Fix misspelling of firmware in tg3.c

---

 drivers/net/tg3.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/tg3.c +1 -1
index 5e2dbae..96ede2a 100644
@@ -11130,7 +11130,7 @@ static int __devinit tg3_phy_probe(struct tg3 *tp)
 		return tg3_phy_init(tp);
 
 	/* Reading the PHY ID register can conflict with ASF
-	 * firwmare access to the PHY hardware.
+	 * firmware access to the PHY hardware.
 	 */
 	err = 0;
 	if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||
#7 lore raw

PATCH 7/20 Fix misspelling of firmware in ipw2100.c

In reply to Nick Andrew

Fix misspelling of firmware in ipw2100.c

---

 drivers/net/wireless/ipw2x00/ipw2100.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ipw2x00/ipw2100.c +1 -1
index 823c2bf..9170c23 100644
@@ -2355,7 +2355,7 @@ static void ipw2100_corruption_detected(struct ipw2100_priv *priv, int i)
 		       i * sizeof(struct ipw2100_status));
 
 #ifdef IPW2100_DEBUG_C3
-	/* Halt the fimrware so we can get a good image */
+	/* Halt the firmware so we can get a good image */
 	write_register(priv->net_dev, IPW_REG_RESET_REG,
 		       IPW_AUX_HOST_RESET_REG_STOP_MASTER);
 	j = 5;
#8 lore raw

PATCH 8/20 Fix misspelling of firmware in ipw2200.c

In reply to Nick Andrew

Fix misspelling of firmware in ipw2200.c

---

 drivers/net/wireless/ipw2x00/ipw2200.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ipw2x00/ipw2200.c +1 -1
index 625f2cf..492f5b7 100644
@@ -8827,7 +8827,7 @@ static int ipw_wx_set_mode(struct net_device *dev,
 #endif				/* CONFIG_IPW2200_MONITOR */
 
 	/* Free the existing firmware and reset the fw_loaded
-	 * flag so ipw_load() will bring in the new firmawre */
+	 * flag so ipw_load() will bring in the new firmware */
 	free_firmware();
 
 	priv->ieee->iw_mode = wrqu->mode;
#9 lore raw

PATCH 9/20 Fix misspelling of firmware in cmd.c

In reply to Nick Andrew

Fix misspelling of firmware in cmd.c

---

 drivers/net/wireless/libertas/cmd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/libertas/cmd.c +1 -1
index 639dd02..8c3605c 100644
@@ -1649,7 +1649,7 @@ static struct cmd_ctrl_node *lbs_get_cmd_ctrl_node(struct lbs_private *priv)
 
 /**
  *  @brief This function executes next command in command
- *  pending queue. It will put fimware back to PS mode
+ *  pending queue. It will put firmware back to PS mode
  *  if applicable.
  *
  *  @param priv     A pointer to struct lbs_private structure
#10 lore raw

PATCH 10/20 Fix misspelling of firmware in pci.c

In reply to Nick Andrew

Fix misspelling of firmware in pci.c

---

 drivers/pci/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/pci/pci.c +1 -1
index e491fde..ab2aa4a 100644
@@ -544,7 +544,7 @@ void pci_update_current_state(struct pci_dev *dev, pci_power_t state)
  * @dev: PCI device to handle.
  * @state: PCI power state (D0, D1, D2, D3hot) to put the device into.
  *
- * Transition a device to a new power state, using the platform formware and/or
+ * Transition a device to a new power state, using the platform firmware and/or
  * the device's PCI PM registers.
  *
  * RETURN VALUE:
#11 lore raw

PATCH 11/20 Fix misspelling of firmware in ueagle-atm.c

In reply to Nick Andrew

Fix misspelling of firmware in ueagle-atm.c

---

 drivers/usb/atm/ueagle-atm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/atm/ueagle-atm.c +1 -1
index b6483dd..9cf9ff6 100644
@@ -626,7 +626,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, void *conte
 		goto err_fw_corrupted;
 
 	/*
-	 * Start to upload formware : send reset
+	 * Start to upload firmware : send reset
 	 */
 	value = 1;
 	ret = uea_send_modem_cmd(usb, F8051_USBCS, sizeof(value), &value);
#12 lore raw

PATCH 12/20 Fix misspelling of firmware in ChangeLog.history

In reply to Nick Andrew

Fix misspelling of firmware in ChangeLog.history

---

 drivers/usb/serial/ChangeLog.history |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/serial/ChangeLog.history +1 -1
index c1b2799..f13fd48 100644
@@ -715,7 +715,7 @@ io_edgeport.c Change Log comments:
 
  0.2 (01/30/2000) greg kroah-hartman
 	Milestone 1 release.
-	Device is found by USB subsystem, enumerated, fimware is downloaded
+	Device is found by USB subsystem, enumerated, firmware is downloaded
 	and the descriptors are printed to the debug log, config is set, and
 	green light starts to blink. Open port works, and data can be sent
 	and received at the default settings of the UART. Loopback connector
#13 lore raw

PATCH 13/20 Fix misspelling of firmware in libata.h

In reply to Nick Andrew

Fix misspelling of firmware in libata.h

---

 include/linux/libata.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/libata.h +1 -1
index 2c6bd66..76bc61f 100644
@@ -377,7 +377,7 @@ enum {
 	ATA_HORKAGE_BRIDGE_OK	= (1 << 10),	/* no bridge limits */
 	ATA_HORKAGE_ATAPI_MOD16_DMA = (1 << 11), /* use ATAPI DMA for commands
 						    not multiple of 16 bytes */
-	ATA_HORKAGE_FIRMWARE_WARN = (1 << 12),	/* firwmare update warning */
+	ATA_HORKAGE_FIRMWARE_WARN = (1 << 12),	/* firmware update warning */
 
 	 /* DMA mask for user DMA control: User visible values; DO NOT
 	    renumber */
#14 lore raw

PATCH 14/20 Fix misspelling of firmware in disk.c

In reply to Nick Andrew

Fix misspelling of firmware in disk.c

---

 kernel/power/disk.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/power/disk.c +2 -2
index 45e8541..760e863 100644
@@ -249,7 +249,7 @@ static int create_image(int platform_mode)
  *	hibernation_snapshot - quiesce devices and create the hibernation
  *	snapshot image.
  *	@platform_mode - if set, use the platform driver, if available, to
- *			 prepare the platform frimware for the power transition.
+ *			 prepare the platform firmware for the power transition.
  *
  *	Must be called with pm_mutex held
  */
@@ -360,7 +360,7 @@ static int resume_target_kernel(void)
  *	hibernation_restore - quiesce devices and restore the hibernation
  *	snapshot image.  If successful, control returns in hibernation_snaphot()
  *	@platform_mode - if set, use the platform driver, if available, to
- *			 prepare the platform frimware for the transition.
+ *			 prepare the platform firmware for the transition.
  *
  *	Must be called with pm_mutex held
  */
#15 lore raw

PATCH 15/20 Fix misspelling of firmware in pss.c

In reply to Nick Andrew

Fix misspelling of firmware in pss.c

---

 sound/oss/pss.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/oss/pss.c +1 -1
index 16ed069..902b39e 100644
@@ -46,7 +46,7 @@
  *          load the driver as it did in previous versions.
  * 04-07-1999: Anthony Barbachan <[email protected]>
  *          Added module parameter pss_firmware to allow the user to tell 
- *          the driver where the fireware file is located.  The default 
+ *          the driver where the firmware file is located.  The default 
  *          setting is the previous hardcoded setting "/etc/sound/pss_synth".
  * 00-03-03: Christoph Hellwig <[email protected]>
  *	    Adapted to module_init/module_exit
#16 lore raw

PATCH 16/20 Fix misspelling of firmware in aica.c

In reply to Nick Andrew

Fix misspelling of firmware in aica.c

---

 sound/sh/aica.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/sh/aica.c +1 -1
index 7c920f3..b1a5229 100644
@@ -565,7 +565,7 @@ static int load_aica_firmware(void)
 	err = request_firmware(&fw_entry, "aica_firmware.bin", &pd->dev);
 	if (unlikely(err))
 		return err;
-	/* write firware into memory */
+	/* write firmware into memory */
 	spu_disable();
 	spu_memload(0, fw_entry->data, fw_entry->size);
 	spu_enable();
#17 lore raw

PATCH 17/20 Fix misspelling of firmware in head_64.S

In reply to Nick Andrew

Fix misspelling of firmware in head_64.S

---

 arch/sparc/kernel/head_64.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sparc/kernel/head_64.S +1 -1
index 8ffee71..fcd0810 100644
@@ -686,7 +686,7 @@ tlb_fixup_done:
 	 * point.
 	 *
 	 * There used to be enormous complexity wrt. transferring
-	 * over from the firwmare's trap table to the Linux kernel's.
+	 * over from the firmware's trap table to the Linux kernel's.
 	 * For example, there was a chicken & egg problem wrt. building
 	 * the OBP page tables, yet needing to be on the Linux kernel
 	 * trap table (to translate PAGE_OFFSET addresses) in order to
#18 lore raw

PATCH 18/20 Fix misspelling of firmware in hpmain.c

In reply to Nick Andrew

Fix misspelling of firmware in hpmain.c

---

 drivers/staging/otus/hal/hpmain.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/otus/hal/hpmain.c +1 -1
index 2e65c46..dab2783 100644
@@ -152,7 +152,7 @@ u16_t zfHpInit(zdev_t* dev, u32_t frequency)
     else
     {
     #ifndef ZM_OTUS_LINUX_PHASE_2
-        /* donwload the normal frimware */
+        /* download the normal firmware */
         if ((ret = zfFirmwareDownload(dev, (u32_t*)zcFwImage,
                 (u32_t)zcFwImageSize, ZM_FIRMWARE_WLAN_ADDR)) != ZM_SUCCESS)
         {
#19 lore raw

PATCH 19/20 Fix misspelling of firmware in iwl3945-base.c

In reply to Nick Andrew

Fix misspelling of firmware in iwl3945-base.c

---

 drivers/net/wireless/iwlwifi/iwl3945-base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/iwlwifi/iwl3945-base.c +1 -1
index d645808..85e465f 100644
@@ -5361,7 +5361,7 @@ static int iwl3945_read_ucode(struct iwl3945_priv *priv)
 
 	/* api_ver should match the api version forming part of the
 	 * firmware filename ... but we don't check for that and only rely
-	 * on the API version read from firware header from here on forward */
+	 * on the API version read from firmware header from here on forward */
 
 	if (api_ver < api_min || api_ver > api_max) {
 		IWL_ERROR("Driver unable to support your firmware API. "
#20 lore raw

PATCH 20/20 Fix misspelling of firmware in iwl-agn.c

In reply to Nick Andrew

Fix misspelling of firmware in iwl-agn.c

---

 drivers/net/wireless/iwlwifi/iwl-agn.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/iwlwifi/iwl-agn.c +1 -1
index 5da6b35..9740b6d 100644
@@ -1623,7 +1623,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)
 
 	/* api_ver should match the api version forming part of the
 	 * firmware filename ... but we don't check for that and only rely
-	 * on the API version read from firware header from here on forward */
+	 * on the API version read from firmware header from here on forward */
 
 	if (api_ver < api_min || api_ver > api_max) {
 		IWL_ERROR("Driver unable to support your firmware API. "
#21 lore raw
In reply to Nick Andrew
Quoted 19 lines · Nick Andrew

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are comment changes.

Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c Fix misspelling of firmware in iwl3945-base.c Fix misspelling of firmware in hpmain.c Fix misspelling of firmware in head_64.S Fix misspelling of firmware in aica.c Fix misspelling of firmware in pss.c Fix misspelling of firmware in disk.c Fix misspelling of firmware in libata.h Fix misspelling of firmware in ChangeLog.history Fix misspelling of firmware in ueagle-atm.c Fix misspelling of firmware in pci.c Fix misspelling of firmware in cmd.c

Quoted 8 lines

Fix misspelling of firmware in ipw2200.c Fix misspelling of firmware in ipw2100.c Fix misspelling of firmware in tg3.c Fix misspelling of firmware in sb1250-mac.c Fix misspelling of firmware in thinkpad_acpi.c Fix misspelling of "firmware" in ip27-smp.c Fix misspelling of "firmware" in firmware.txt Fix misspelling of "firmware" in ia64-kvm.txt

Please send one patch next time, nobody wants to see 20 trivial emails.

#22 lore raw
In reply to Nick Andrew
Quoted 18 lines · Nick Andrew

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are comment changes.
Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c Fix misspelling of firmware in iwl3945-base.c Fix misspelling of firmware in hpmain.c Fix misspelling of firmware in head_64.S Fix misspelling of firmware in aica.c Fix misspelling of firmware in pss.c Fix misspelling of firmware in disk.c Fix misspelling of firmware in libata.h Fix misspelling of firmware in ChangeLog.history Fix misspelling of firmware in ueagle-atm.c Fix misspelling of firmware in pci.c Fix misspelling of firmware in cmd.c

Quoted 8 lines

Fix misspelling of firmware in ipw2200.c Fix misspelling of firmware in ipw2100.c Fix misspelling of firmware in tg3.c Fix misspelling of firmware in sb1250-mac.c Fix misspelling of firmware in thinkpad_acpi.c Fix misspelling of "firmware" in ip27-smp.c Fix misspelling of "firmware" in firmware.txt Fix misspelling of "firmware" in ia64-kvm.txt

I will fold all this into single patch and apply.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#23 lore raw
Quoted 31 lines · Jiri Kosina
Quoted 18 lines · Nick Andrew

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are comment changes.
Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c Fix misspelling of firmware in iwl3945-base.c Fix misspelling of firmware in hpmain.c Fix misspelling of firmware in head_64.S Fix misspelling of firmware in aica.c Fix misspelling of firmware in pss.c Fix misspelling of firmware in disk.c Fix misspelling of firmware in libata.h Fix misspelling of firmware in ChangeLog.history Fix misspelling of firmware in ueagle-atm.c Fix misspelling of firmware in pci.c Fix misspelling of firmware in cmd.c

Quoted 9 lines

Fix misspelling of firmware in ipw2200.c Fix misspelling of firmware in ipw2100.c Fix misspelling of firmware in tg3.c Fix misspelling of firmware in sb1250-mac.c Fix misspelling of firmware in thinkpad_acpi.c Fix misspelling of "firmware" in ip27-smp.c Fix misspelling of "firmware" in firmware.txt Fix misspelling of "firmware" in ia64-kvm.txt

Quoted 5 lines

I will fold all this into single patch and apply.

Thanks,

"Fix misspelling of firmware in tg3.c" didn't help me to solve tg3 firmware issue which I submitted via "[BUG] tg3 module problem on Linux-2.6.29-rc1-2" subjected email at 21st of Jan. I re-compiled 2.6.29-rc2 with this patch and still having the same error message :

Using mkinitramfs-kpkg to build the ramdisk.
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin for module tg3

Tarkan ERIMER

#24 lore raw
Quoted 11 lines · Tarkan Erimer

"Fix misspelling of firmware in tg3.c" didn't help me to solve tg3 firmware issue which I submitted via "[BUG] tg3 module problem on Linux-2.6.29-rc1-2" subjected email at 21st of Jan. I re-compiled 2.6.29-rc2 with this patch and still having the same error message :
Using mkinitramfs-kpkg to build the ramdisk.
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin for module tg3

Yes, Nick's patch is not supposed to fix this, it's just a fix of a comment in the source code, that has no effect on the behavior of the driver. So this is completely separate issue, that you should report to the proper place, which is

BROADCOM TG3 GIGABIT ETHERNET DRIVER
P: Michael Chan
M: [email protected]
L: [email protected]
S: Supported

Signature · 2 lines
Jiri Kosina
SUSE Labs
#25 lore raw
Quoted 9 lines · Jiri Kosina

Yes, Nick's patch is not supposed to fix this, it's just a fix of a comment in the source code, that has no effect on the behavior of the driver. So this is completely separate issue, that you should report to the proper place, which is

BROADCOM TG3 GIGABIT ETHERNET DRIVER
P: Michael Chan
M: [email protected]
L: [email protected]
S: Supported

Arrrgghhh! I got it. Sorry for the noise :-)
Ok, thanks for pointing. I'll report it to the proper place/people.

Tarkan ERIMER

#26 lore raw
In reply to Tarkan Erimer
Quoted 46 lines · Tarkan Erimer
Quoted 34 lines · Jiri Kosina
Quoted 20 lines · Nick Andrew

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are
comment changes.
Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c Fix misspelling of firmware in iwl3945-base.c Fix misspelling of firmware in hpmain.c Fix misspelling of firmware in head_64.S Fix misspelling of firmware in aica.c Fix misspelling of firmware in pss.c Fix misspelling of firmware in disk.c Fix misspelling of firmware in libata.h Fix misspelling of firmware in ChangeLog.history Fix misspelling of firmware in ueagle-atm.c Fix misspelling of firmware in pci.c Fix misspelling of firmware in cmd.c

Quoted 9 lines

Fix misspelling of firmware in ipw2200.c Fix misspelling of firmware in ipw2100.c Fix misspelling of firmware in tg3.c Fix misspelling of firmware in sb1250-mac.c Fix misspelling of firmware in thinkpad_acpi.c Fix misspelling of "firmware" in ip27-smp.c Fix misspelling of "firmware" in firmware.txt Fix misspelling of "firmware" in ia64-kvm.txt

Quoted 5 lines

I will fold all this into single patch and apply.

Thanks,

"Fix misspelling of firmware in tg3.c" didn't help me to solve tg3 firmware issue which I submitted via "[BUG] tg3 module problem on Linux-2.6.29-rc1-2" subjected email at 21st of Jan. I re-compiled 2.6.29-rc2 with this patch and still having the same error message :

Quoted 9 lines

Using mkinitramfs-kpkg to build the ramdisk.
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin for module tg3

I send post to your original thread and also also CC to concern persons.

--
JSR

#27 lore raw
Quoted 5 lines · Jaswinder Singh Rajput

I send post to your original thread and also also CC to concern persons.

--
JSR

Thanks. I already replied it.

Tarkan ERIMER

#28 lore raw
In reply to Jiri Kosina
Quoted 1 line · Jiri Kosina

I will fold all this into single patch and apply.

Ok Jiri. Just to note - last time I submitted a single patch like this ("fix use of loose" in April 2008) to trivial@, the patch frequently failed to merge due to some of the files being modified, renamed etc in the meantime, and the patch got dropped. When I split it into one patch per file and sent them to subsystem maintainers, about 90% of the patches were merged.

So my impression is that multiple single file patches are more successful. It should be easier for you to drop any patches which fail to merge due to other work. But if you think a single patch is best, I'll submit a single patch.

Nick.