don't blindly use xmalloc() for allocating struct domain instances
PATCH 1/1 don't blindly use xmalloc() for allocating struct domain instances
At least on x86 these structures are greater than a page anyway, and hence using xmalloc is wasteful here.
Signed-off-by Jan Beulich <[email protected]>
xen/common/domain.c +7 -2
@@ -104,12 +104,17 @@ int current_domain_id(void)static struct domain *alloc_domain_struct (void ) { - return xmalloc(struct domain); +if (sizeof (struct domain ) <PAGE_SIZE ) + return xmalloc(struct domain); +return alloc_xenheap_pages (get_order_from_bytes (sizeof (struct domain ))); }static void free_domain_struct (struct domain *d) { -xfree (d); +if (sizeof (*d) <PAGE_SIZE ) +xfree (d); +else +free_xenheap_pages (d,get_order_from_bytes (sizeof (*d))); }static void __domain_finalise_shutdown (struct domain *d)
The xmalloc overhead is tiny. This is only worth it if we're actually going to pickle the domptr in page_info again. Which actually we might well do, but then we can do something like this as part of that patch.
-- Keir
Quoted 35 lines · Jan Beulich
At least on x86 these structures are greater than a page anyway, and hence using xmalloc is wasteful here.
Signed-off-by Jan Beulich <[email protected]>xen/common/domain.c 2009-01-27 11:47:22.000000000 +0100 renamed from xen/common/domain.c 2009-01-08 10:30:05.000000000 +0100 +7
-2@@ -104,12 +104,17 @@ int current_domain_id(void) static struct domain *alloc_domain_struct(void) { - return xmalloc(struct domain); + if (sizeof(struct domain) < PAGE_SIZE) + return xmalloc(struct domain); + return alloc_xenheap_pages(get_order_from_bytes(sizeof(struct domain))); } static void free_domain_struct(struct domain *d) { - xfree(d); + if (sizeof(*d) < PAGE_SIZE) + xfree(d); + else + free_xenheap_pages(d, get_order_from_bytes(sizeof(*d))); } static void __domain_finalise_shutdown(struct domain *d)_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel