sata_mv: Test patch for Hightpoint RocketRaid 1740/1742
PATCH 1/1 sata_mv: Test patch for Hightpoint RocketRaid 1740/1742
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
ata/sata_mv.c renamed from ata/sata_mv.c~ +3 -0
@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x }, { PCI_VDEVICE(MARVELL, 0x6040), chip_604x }, { PCI_VDEVICE(MARVELL, 0x6041), chip_604x },
Quoted 8 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>
ata/sata_mv.c line 578
Quoted 6 lines
ata/sata_mv.c renamed from ata/sata_mv.c~ +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },
If your testers could re-test on top of what I just submitted to Linus, that would be most helpful. My non-RocketRAID 5081 works just fine, but sata_mv received some major changes and bug fixes, which could potentially change behavior here.
Since we're guessing (I assume?), I definitely want to make sure we have the correct MV variant for use with RocketRAID.
Any idea if RocketRAID is marketed as SATA-II or with NCQ support? ("queueing" in marketing lit doesn't help, alas).
Jeff
Quoted 2 lines
Since we're guessing (I assume?), I definitely want to make sure we have the correct MV variant for use with RocketRAID.
We are not guessing. There is sufficient information in the driver to identify the specific chip variant
Quoted 26 lines · Alan Cox
Quoted 23 lines · On Sat, 01 Sep 2007 15:38:43 +0200 Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
Quoted 21 lines · Alan Cox
Quoted 6 lines · On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
Quoted 5 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[EMAIL PROTECTED]>Quoted 10 lines
ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100 line 578
Quoted 9 lines
ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100 renamed from ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100 +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, + /* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },Is this still a test patch, or can it go upstream?
Upstream
Quoted 7 lines
Quoted 1 line
Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] pictures there may be a 6042 chipset (GEN IIe) placed onboard.
The ones I checked and the code used as a reference clearly indicate a 508x. I've had two reports of a TTI 0x23xx ID number which may perhaps be a 6042 as it didn't appear to work with a 508x driver.
Alan
..
Dredging up an old posting here:
Alan/Jeff, I've now got two reports that the above patch is not correct for the Highpoint RocketRAID 1740 cards.
PCI ID 1103:1740 is clearly a Marvell 6042 chip, not a 5081.
Patch to correct this is coming shortly.
Cheers
PATCH 1/1 sata_mv: Fix chip type for Hightpoint RocketRaid 1740
Fix chip type for the Highpoint RocketRAID 1740 4-port PCI(-X) card. It really has a Marvell 6042 on it, rather than a (8-port) 5081 chip. Confirmed by multiple (two) users.
---
This patch is a candidate for linux-stable as well.
drivers/ata/sata_mv.c +0 -0
@@ -663,7 +663,7 @@
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
/* RocketRAID 1720/174x have different identifiers */
{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },
- { PCI_VDEVICE(TTI, 0x1740), chip_508x },
+ { PCI_VDEVICE(TTI, 0x1740), chip_6042 },
{ PCI_VDEVICE(TTI, 0x1742), chip_508x },
{ PCI_VDEVICE(MARVELL, 0x6040), chip_604x },Re: [PATCH] sata_mv: Fix chip type for Hightpoint RocketRaid 1740
Quoted 12 lines · Mark Lord
Fix chip type for the Highpoint RocketRAID 1740 4-port PCI(-X) card. It really has a Marvell 6042 on it, rather than a (8-port) 5081 chip. Confirmed by multiple (two) users.
Signed-off-by Mark Lord <[email protected]>---
This patch is a candidate for linux-stable as well.
drivers/ata/sata_mv.c 2009-01-27 16:05:15.000000000 -0500 line 669
Quoted 8 lines
drivers/ata/sata_mv.c 2009-01-27 16:05:15.000000000 -0500 renamed from drivers/ata/sata_mv.c 2009-01-27 16:03:08.000000000 -0500 +1
-1@@ -663,7 +663,7 @@ { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, /* RocketRAID 1720/174x have different identifiers */ { PCI_VDEVICE(TTI, 0x1720), chip_6042 }, - { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1740), chip_6042 }, { PCI_VDEVICE(TTI, 0x1742), chip_508x }, { PCI_VDEVICE(MARVELL, 0x6040), chip_604x },
..
Here's some definitive supporting documentation:
http://www.highpoint-tech.com/image/products/SATAII/RR1740_card_big.jpg
Cheers
PATCH 1/1 sata_mv: Fix chip type for Hightpoint RocketRaid 1740/1742
In reply to Mark LordFix chip type for the Highpoint RocketRAID 1740 and 1742 PCI cards. These really do have Marvell 6042 chips on them, rather than the 5081 chip.
Confirmed by multiple (two) users (for the 1740), and by examining the product photographs from Highpoint's web site.
---
This replaces the earlier 1740-only version of the patch. This patch is a candidate for linux-stable as well.
drivers/ata/sata_mv.c +0 -0
@@ -663,8 +663,8 @@
{ PCI_VDEVICE(MARVELL, 0x5081), chip_508x },
/* RocketRAID 1720/174x have different identifiers */
{ PCI_VDEVICE(TTI, 0x1720), chip_6042 },- { PCI_VDEVICE(TTI, 0x1740), chip_508x },
- { PCI_VDEVICE(TTI, 0x1742), chip_508x },
+ { PCI_VDEVICE(TTI, 0x1740), chip_6042 },
+ { PCI_VDEVICE(TTI, 0x1742), chip_6042 },
{ PCI_VDEVICE(MARVELL, 0x6040), chip_604x },
{ PCI_VDEVICE(MARVELL, 0x6041), chip_604x },Jeff Garzik
AppliedRe: [PATCH] sata_mv: Fix chip type for Hightpoint RocketRaid 1740/1742
Quoted 14 lines · Mark Lord
Fix chip type for the Highpoint RocketRAID 1740 and 1742 PCI cards. These really do have Marvell 6042 chips on them, rather than the 5081 chip.
Confirmed by multiple (two) users (for the 1740), and by examining the product photographs from Highpoint's web site.
Signed-off-by Mark Lord <[email protected]>---
This replaces the earlier 1740-only version of the patch. This patch is a candidate for linux-stable as well.
drivers/ata/sata_mv.c 2009-01-27 16:28:15.000000000 -0500 line 669
Quoted 9 lines
drivers/ata/sata_mv.c 2009-01-27 16:28:15.000000000 -0500 renamed from drivers/ata/sata_mv.c 2009-01-27 16:03:08.000000000 -0500 +2
-2@@ -663,8 +663,8 @@ { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, /* RocketRAID 1720/174x have different identifiers */ { PCI_VDEVICE(TTI, 0x1720), chip_6042 }, - { PCI_VDEVICE(TTI, 0x1740), chip_508x }, - { PCI_VDEVICE(TTI, 0x1742), chip_508x }, + { PCI_VDEVICE(TTI, 0x1740), chip_6042 }, + { PCI_VDEVICE(TTI, 0x1742), chip_6042 }, { PCI_VDEVICE(MARVELL, 0x6040), chip_604x },
applied
Quoted 8 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>
ata/sata_mv.c line 578
Quoted 6 lines
ata/sata_mv.c renamed from ata/sata_mv.c~ +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },
Is this still a test patch, or can it go upstream?
Jeff
Quoted 6 lines · On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 5 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>
Quoted 11 lines
ata/sata_mv.c line 578
Quoted 9 lines
ata/sata_mv.c renamed from ata/sata_mv.c~ +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },Is this still a test patch, or can it go upstream?
Upstream
Quoted 20 lines · Alan Cox
Quoted 6 lines · On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 5 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>Quoted 10 lines
ata/sata_mv.c line 578
Quoted 9 lines
ata/sata_mv.c renamed from ata/sata_mv.c~ +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },Is this still a test patch, or can it go upstream?
Quoted 1 line
Upstream
Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] pictures there may be a 6042 chipset (GEN IIe) placed onboard.
[1] http://www.highpoint-tech.com/image/products/SATAII/RR1740_card_big.jpg
http://www.highpoint-tech.com/image/products/eSATA/RR1742_card_big.jpg
Best regards,
Krzysztof Olędzki
Quoted 21 lines · Krzysztof Oledzki
Quoted 20 lines · Alan Cox
Quoted 16 lines · On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 8 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100 line 578
Quoted 6 lines
ata/sata_mv.c 2007-07-09 13:19:57.004052752 +0100 renamed from ata/sata_mv.c~ 2007-07-09 13:19:57.003052904 +0100 +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, + /* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },Is this still a test patch, or can it go upstream?
Quoted 6 lines
Quoted 1 line
Upstream
Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] pictures there may be a 6042 chipset (GEN IIe) placed onboard.
[1] http://www.highpoint-tech.com/image/products/SATAII/RR1740_card_big.jpg
http://www.highpoint-tech.com/image/products/eSATA/RR1742_card_big.jpg
Good evidence!
"SATAII" is also an indicator that it is not 508x.
Jeff
Quoted 21 lines · On Sat, 01 Sep 2007 15:38:43 +0200 Krzysztof Oledzki <[email protected]> wrote:
Quoted 20 lines · Alan Cox
Quoted 16 lines · On Wed, 01 Aug 2007 09:49:19 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 8 lines · Alan Cox
Underneath all the HPT packaging, PCI identifiers, binary driver modules and stuff you find that ...
Signed-off-by Alan Cox <[email protected]>ata/sata_mv.c line 578
Quoted 6 lines
ata/sata_mv.c renamed from ata/sata_mv.c~ +3
-0@@ -573,6 +573,9 @@ { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, +/* RocketRAID 1740/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1740), chip_508x }, + { PCI_VDEVICE(TTI, 0x1742), chip_508x },Is this still a test patch, or can it go upstream?
Quoted 4 lines
Quoted 1 line
Upstream
Are you sure that 1740/1742 are 508x (GEN I)? According to these [1] pictures there may be a 6042 chipset (GEN IIe) placed onboard.
The ones I checked and the code used as a reference clearly indicate a 508x. I've had two reports of a TTI 0x23xx ID number which may perhaps be a 6042 as it didn't appear to work with a 508x driver.
Alan