Skip to contentSkip to conversation

smackfs load append mode fix

PATCH New Casey Schaufler 1 participant 1 message Jan 28, 2009

Subsystems (2)
lore
Share & tools
lore

Casey Schaufler

author maintainer
#0 lore raw

PATCH 1/1 smackfs load append mode fix

From: Casey Schaufler <[email protected]>

Given just how hard it is to find the code that uses MAY_APPEND it's probably not a big surprise that this went unnoticed for so long. The Smack rules loading code is incorrectly setting the MAY_READ bit when MAY_APPEND is requested.

---

security/smack/smackfs.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
security/smack/smackfs.c +0 -0
diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6/security/smack/smackfs.c linux-0112/security/smack/smackfs.c
@@ -334,7 +334,7 @@ static ssize_t smk_write_load(struct fil
		break;
	case 'a':
	case 'A':
-		rule.smk_access |= MAY_READ;
+		rule.smk_access |= MAY_APPEND;
		break;
	default:
		goto out;