Skip to contentSkip to conversation

Skip identical lines in hexdump

PATCH In review Christian Franke 1 participant 2 messages Jan 30, 2009 – Feb 2, 2009 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Skip identical lines in hexdump

This skips identical lines in hexdump output, like 'od' or 'xxd -a' also do.

Christian

PS: I would suggest to change hexdump 'buf' parameter from 'char *' to 'const void *' to avoid unnecessary casts.

2009-01-30 Christian Franke <[email protected]>

* lib/hexdump.c (hexdump): Print at most 3 lines if data is identical.

lib/hexdump.c +16 -0
index 9b79f45..7689edf 100644
@@ -61,6 +61,22 @@ hexdump (unsigned long bse, char *buf, int len)
 
       grub_printf ("%s\n", line);
 
+      /* Print only first and last line of more than 3 lines are identical.  */
+      if (len >= 4 * 16
+	  && ! grub_memcmp (buf, buf + 1 * 16, 16)
+	  && ! grub_memcmp (buf, buf + 2 * 16, 16)
+	  && ! grub_memcmp (buf, buf + 3 * 16, 16))
+	{
+	  grub_printf ("*\n");
+	  do
+	    {
+	      bse += 16;
+	      buf += 16;
+	      len -= 16;
+	    }
+	  while (len >= 3 * 16 && ! grub_memcmp (buf, buf + 2 * 16, 16));
+	}
+
       bse += 16;
       buf += 16;
       len -= cnt;
#1 lore raw
Quoted 2 lines · Christian Franke

This skips identical lines in hexdump output, like 'od' or 'xxd -a' also do.

Committed.

Christian