hso: add new device id's
Subsystems (4)
PATCH 1/1 hso: add new device id's
This patch adds a few device id's and removes one which will never be used.
---
This patch adds a few device id's and removes one which will never be used.
---
drivers/net/usb/hso.c +3 -1
@@ -455,6 +455,7 @@ static const struct usb_device_id hso_ids[] = { {icon321_port_device(0x0af0, 0xd033)}, /* Icon-322 */ {USB_DEVICE(0x0af0, 0x7301)}, /* GE40x */ {USB_DEVICE(0x0af0, 0x7361)}, /* GE40x */ + {USB_DEVICE(0x0af0, 0x7381)}, /* GE40x */ {USB_DEVICE(0x0af0, 0x7401)}, /* GI 0401 */ {USB_DEVICE(0x0af0, 0x7501)}, /* GTM 382 */ {USB_DEVICE(0x0af0, 0x7601)}, /* GE40x */
@@ -462,7 +463,8 @@ static const struct usb_device_id hso_ids[] = { {USB_DEVICE(0x0af0, 0x7801)}, {USB_DEVICE(0x0af0, 0x7901)}, {USB_DEVICE(0x0af0, 0x7361)}, - {icon321_port_device(0x0af0, 0xd051)}, + {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0xd055)}, {} };MODULE_DEVICE_TABLE (usb, hso_ids);
A message that is not in the archive (sent off-list or not yet received): [email protected]
From: Filip Aben <[email protected]>
Date: Mon, 02 Feb 2009 15:59:05 +0100
Quoted 3 lines
This patch adds a few device id's and removes one which will never be used.
Signed-off-by Filip Aben <[email protected]>
Why won't 0xaf0/0xd051 ever be used?
You should explain such things in your commit message,
that way I don't have to ask.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20090202.140240.230022378.davem-fT/PcQaiUtIeIZ0/[email protected]
Quoted 9 lines
-----Original Message-----
From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/[email protected]]
Sent: maandag 2 februari 2009 23:03
To: Filip Aben
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] hso: add new device id's
Quoted 4 lines
From: Filip Aben <[email protected]>
Date: Mon, 02 Feb 2009 15:59:05 +0100Quoted 1 line
This patch adds a few device id's and removes one which will never
be
Quoted 8 lines
used.
Quoted 2 lines
Signed-off-by Filip Aben <[email protected]>Why won't 0xaf0/0xd051 ever be used?
You should explain such things in your commit message, that way I don't have to ask.
That ID was used in an internal engineering version of a device and will never see commercial light.
Even if this ID will be 'recycled' in the future, which is very unlikely,
I don't know what kind of device will be behind it. Therefore it's safer to remove it.
Regards,
Filip-
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 4ADF55C1EB3643428CD4FAE5C129EF950258CD97-XlSf7ELR9ZHcV2kYEOvnW/[email protected]
From: "Filip Aben" <[email protected]>
Date: Tue, 3 Feb 2009 01:26:14 +0100
Quoted 12 lines
Quoted 11 lines
-----Original Message-----
From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/[email protected]]
Sent: maandag 2 februari 2009 23:03
To: Filip Aben
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] hso: add new device id'sWhy won't 0xaf0/0xd051 ever be used?
You should explain such things in your commit message, that way I don't have to ask.
Quoted 6 lines
That ID was used in an internal engineering version of a device and will never see commercial light.
Even if this ID will be 'recycled' in the future, which is very unlikely,
I don't know what kind of device will be behind it. Therefore it's safer to remove it.
Great, please add that information to the commit message and resend your patch.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html