Skip to contentSkip to conversation

wireless: pos[4] tested twice, 2nd should be pos[5]

PATCH In review Roel Kluin 2 participants 2 messages Feb 3, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 wireless: pos[4] tested twice, 2nd should be pos[5]

Is this what it should be? please review. ----------------->8----------------------8<------------------

pos[4] can't be both 0x43 and 0x04, 2nd should be pos[5]

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/wireless/libertas/scan.c +1 -1
index 57f6c12..00a57ed 100644
@@ -692,7 +692,7 @@ static int lbs_process_bss(struct bss_descriptor *bss,
 					    bss->wpa_ie_len);
 			} else if (pos[1] >= MARVELL_MESH_IE_LENGTH &&
 				   pos[2] == 0x00 && pos[3] == 0x50 &&
-				   pos[4] == 0x43 && pos[4] == 0x04) {
+				   pos[4] == 0x43 && pos[5] == 0x04) {
 				lbs_deb_scan("got mesh IE\n");
 				bss->mesh = 1;
 			} else {
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Roel Kluin

Is this what it should be? please review. ----------------->8----------------------8<------------------

pos[4] can't be both 0x43 and 0x04, 2nd should be pos[5]

Signed-off-by Roel Kluin <[email protected]>
Acked-by Dan Williams <[email protected]>
Quoted 18 lines

---

drivers/net/wireless/libertas/scan.c +1 -2
index 57f6c12..00a57ed 100644
@@ -692,7 +692,7 @@ static int lbs_process_bss(struct bss_descriptor *bss,
 					    bss->wpa_ie_len);
 			} else if (pos[1] >= MARVELL_MESH_IE_LENGTH &&
 				   pos[2] == 0x00 && pos[3] == 0x50 &&
-				   pos[4] == 0x43 && pos[4] == 0x04) {
+				   pos[4] == 0x43 && pos[5] == 0x04) {
 				lbs_deb_scan("got mesh IE\n");
 				bss->mesh = 1;
 			} else {
--

To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html