ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
Subsystems (3)
PATCH 1/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and using output-low DT property leads to the GPIO being set high instead.
--- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +1 -1
@@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog; - gpios = <13 GPIO_ACTIVE_LOW>; + gpios = <13 0>; output-low; line-name = "usb-port-power"; };
Signature · 1 line
2.29.2
PATCH 1/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
Quoted 3 lines · Marek Vasut
The GPIO hog flags are ignored by
gpiolib-of.cnow, set the flags to 0. Due to a change ingpiolib-of.c, setting flags toGPIO_ACTIVE_LOWand using output-low DT property leads to the GPIO being set high instead.
+CC Tom
These two should be applied to 2021.01 as well, can you pick them ? Thanks
PATCH 2/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
In reply to Marek VasutThe GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0. Since GPIO_ACTIVE_HIGH is defined as 0, this change only increases the correctness of the DT.
--- arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +2 -2
@@ -37,7 +37,7 @@ */ usb-hub { gpio-hog; - gpios = <8 GPIO_ACTIVE_HIGH>; + gpios = <8 0>; output-high; line-name = "rs485-rx-en"; };
@@ -65,7 +65,7 @@ */ usb-hub { gpio-hog; - gpios = <2 GPIO_ACTIVE_HIGH>; + gpios = <2 0>; output-high; line-name = "usb-hub-reset"; };
Signature · 1 line
2.29.2
PATCH 2/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
Hi Marek
Quoted 25 lines · Marek Vasut
The GPIO hog flags are ignored by
gpiolib-of.cnow, set the flags to 0. SinceGPIO_ACTIVE_HIGHis defined as 0, this change only increases the correctness of the DT.Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +1
-1@@ -37,7 +37,7 @@ */ usb-hub { gpio-hog; - gpios = <8 GPIO_ACTIVE_HIGH>; + gpios = <8 0>; output-high; line-name = "rs485-rx-en"; };
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts line 71
Quoted 8 lines
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +1
-1@@ -65,7 +65,7 @@ */ usb-hub { gpio-hog; - gpios = <2 GPIO_ACTIVE_HIGH>; + gpios = <2 0>; output-high; line-name = "usb-hub-reset"; };
Thanks
PATCH 2/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM DRC02
In reply to Marek VasutQuoted 25 lines · Marek Vasut
The GPIO hog flags are ignored by
gpiolib-of.cnow, set the flags to 0. SinceGPIO_ACTIVE_HIGHis defined as 0, this change only increases the correctness of the DT.Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +1
-1@@ -37,7 +37,7 @@ */ usb-hub { gpio-hog; - gpios = <8 GPIO_ACTIVE_HIGH>; + gpios = <8 0>; output-high; line-name = "rs485-rx-en"; };
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts line 71
Quoted 8 lines
arch/arm/dts/stm32mp15xx-dhcom-drc02.dts +1
-1@@ -65,7 +65,7 @@ */ usb-hub { gpio-hog; - gpios = <2 GPIO_ACTIVE_HIGH>; + gpios = <2 0>; output-high; line-name = "usb-hub-reset"; };
Thanks
Patrick
PATCH 1/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
In reply to Marek VasutHi Marek
Quoted 16 lines · Marek Vasut
The GPIO hog flags are ignored by
gpiolib-of.cnow, set the flags to 0. Due to a change ingpiolib-of.c, setting flags toGPIO_ACTIVE_LOWand using output-low DT property leads to the GPIO being set high instead.Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +0
-0
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts line 43
Quoted 8 lines
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +1
-1@@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog; - gpios = <13 GPIO_ACTIVE_LOW>; + gpios = <13 0>; output-low; line-name = "usb-port-power"; };
Thanks
PATCH 1/2 ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
In reply to Marek VasutHi Marek,
Quoted 16 lines · Marek Vasut
The GPIO hog flags are ignored by
gpiolib-of.cnow, set the flags to 0. Due to a change ingpiolib-of.c, setting flags toGPIO_ACTIVE_LOWand using output-low DT property leads to the GPIO being set high instead.Signed-off-by Marek Vasut <[email protected]>Cc Patrice Chotard <[email protected]>Cc Patrick Delaunay <[email protected]>--- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +0
-0
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts line 43
Quoted 8 lines
arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts +1
-1@@ -37,7 +37,7 @@ */ usb-port-power { gpio-hog; - gpios = <13 GPIO_ACTIVE_LOW>; + gpios = <13 0>; output-low; line-name = "usb-port-power"; };
Thanks
Patrick