Skip to contentSkip to conversation

ehea: Fix: Remove adapter from adapter list in error path

PATCH Applied Hannes Hering 3 participants 3 messages Feb 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ehea: Fix: Remove adapter from adapter list in error path

Remove adapter from adapter list before freeing data structure in error path.

---

drivers/net/ehea/ehea.h +1 -1
diff -Nurp -X dontdiff linux-2.6.29-rc4/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
@@ -40,7 +40,7 @@
 #include <asm/io.h>
 
 #define DRV_NAME	"ehea"
-#define DRV_VERSION	"EHEA_0097"
+#define DRV_VERSION	"EHEA_0098"
 
 /* eHEA capability flags */
 #define DLPAR_PORT_ADD_REM 1
drivers/net/ehea/ehea_main.c +1 -0
diff -Nurp -X dontdiff linux-2.6.29-rc4/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
@@ -3448,6 +3448,7 @@ out_kill_eq:
 	ehea_destroy_eq(adapter->neq);
 
 out_free_ad:
+	list_del(&adapter->list);
 	kfree(adapter);
 
 out:
#1 lore raw
Quoted 1 line · Hannes Hering

Remove adapter from adapter list before freeing data structure in error path.

...

drivers/net/ehea/ehea_main.c out_kill_eq: · line 3454

Quoted 10 lines
drivers/net/ehea/ehea_main.c +1 -0
@@ -3448,6 +3448,7 @@ out_kill_eq:
 	ehea_destroy_eq(adapter->neq);
 
 out_free_ad:
+	list_del(&adapter->list);
 	kfree(adapter);
 
 out:

On a related note, ehea_set_mac_addr()/ehea_update_bcmc_registrations() accesses adapter_list without serialization by ehea_fw_handles.lock and thus apparently unsafely.

There may be other unsafe accesses of adapter_list; that's just the first one which I spotted.

Signature · 3 lines
Stefan Richter
-=====-==--= --=- -=-==
http://arcgraph.de/sr/