ehea: Fix: Remove adapter from adapter list in error path
Subsystems (2)
PATCH 1/1 ehea: Fix: Remove adapter from adapter list in error path
Remove adapter from adapter list before freeing data structure in error path.
Signed-off-by Hannes Hering <[email protected]>
---
drivers/net/ehea/ehea.h +1 -1
@@ -40,7 +40,7 @@#include <asm/io.h> #define DRV_NAME "ehea" -#define DRV_VERSION "EHEA_0097" +#define DRV_VERSION "EHEA_0098"/* eHEA capability flags */ #define DLPAR_PORT_ADD_REM 1
drivers/net/ehea/ehea_main.c +1 -0
@@ -3448,6 +3448,7 @@ out_kill_eq:ehea_destroy_eq (adapter->neq); out_free_ad: +list_del (&adapter->list);kfree (adapter); out:
Quoted 1 line · Hannes Hering
Remove adapter from adapter list before freeing data structure in error path.
...
drivers/net/ehea/ehea_main.c out_kill_eq: · line 3454
Quoted 10 lines
drivers/net/ehea/ehea_main.c +1
-0@@ -3448,6 +3448,7 @@ out_kill_eq:ehea_destroy_eq (adapter->neq); out_free_ad: +list_del (&adapter->list);kfree (adapter); out:
On a related note, ehea_set_mac_addr()/ehea_update_bcmc_registrations() accesses adapter_list without serialization by ehea_fw_handles.lock and thus apparently unsafely.
There may be other unsafe accesses of adapter_list; that's just the first one which I spotted.
Signature · 3 lines
Stefan Richter -=====-==--= --=- -=-== http://arcgraph.de/sr/
From: Hannes Hering <[email protected]>
Date: Wed, 11 Feb 2009 13:29:02 +0100
Quoted 3 lines
Remove adapter from adapter list before freeing data structure in error path.
Signed-off-by Hannes Hering <[email protected]>
Applied to net-next-2.6, thanks!