Skip to contentSkip to conversation

mtools-like FAT-label behaviour

PATCH In review phcoder 1 participant 5 messages Feb 11, 2009 – Apr 5, 2009

lore
Share & tools
lore

phcoder

author
#0 lore raw

PATCH 1/1 mtools-like FAT-label behaviour

Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko

ChangeLog +8 -0
Index: ChangeLog
===================================================================
@@ -1,0 +1,8 @@
+2009-02-11  Vladimir Serbinenko  <[email protected]>
+
+	Trim trailing spaces in FAT label and support mtools-like labels
+	
+	* fs/fat.c (grub_fat_iterate_dir): New function based 
+	on grub_fat_find_dir
+	(grub_fat_find_dir): use grub_fat_iterate_dir
+	(grub_fat_label): likewise
fat.c +119 -120

310 lines not on this page · raw message

author
#1 lore raw

With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' Serbinenko

Quoted 4 lines · phcoder

Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko

ChangeLog +8 -0
Index: ChangeLog
===================================================================
@@ -1,0 +1,8 @@
+2009-02-11  Vladimir Serbinenko  <[email protected]>
+
+	Trim trailing spaces in FAT label and support mtools-like labels
+	
+	* fs/fat.c (grub_fat_iterate_dir): New function based 
+	on grub_fat_find_dir
+	(grub_fat_find_dir): use grub_fat_iterate_dir
+	(grub_fat_label): likewise
fat.c +119 -120

310 lines not on this page · raw message

author
#2 lore raw

Applies fine to last SVN

Quoted 9 lines · phcoder

With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' Serbinenko

Quoted 4 lines · phcoder

Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko

Signature · 2 lines
Regards
Vladimir 'phcoder' Serbinenko
author
#3 lore raw

Bean already said on IRC that this patch is fine with him. If I don't recieve any oppositions in 1 week I consider this patch ok for committment

Quoted 13 lines · phcoder

Applies fine to last SVN

Quoted 9 lines · phcoder

With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' Serbinenko

Quoted 4 lines · phcoder

Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko

Signature · 2 lines
Regards
Vladimir 'phcoder' Serbinenko
author
#4 lore raw

Commited

Quoted 17 lines · phcoder

Bean already said on IRC that this patch is fine with him. If I don't recieve any oppositions in 1 week I consider this patch ok for committment

Quoted 13 lines · phcoder

Applies fine to last SVN

Quoted 9 lines · phcoder

With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' Serbinenko

Quoted 4 lines · phcoder

Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko

Signature · 2 lines
Regards
Vladimir 'phcoder' Serbinenko