mtools-like FAT-label behaviour
PATCH 1/1 mtools-like FAT-label behaviour
Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko
ChangeLog +8 -0
@@ -1,0 +1,8 @@ +2009-02-11 Vladimir Serbinenko <[email protected]> + + Trim trailing spaces in FAT label and support mtools-like labels + + * fs/fat.c (grub_fat_iterate_dir): New function based + on grub_fat_find_dir + (grub_fat_find_dir): use grub_fat_iterate_dir + (grub_fat_label): likewise
fat.c +119 -120
310 lines not on this page · raw message
With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' Serbinenko
Quoted 4 lines · phcoder
Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko
ChangeLog +8 -0
@@ -1,0 +1,8 @@ +2009-02-11 Vladimir Serbinenko <[email protected]> + + Trim trailing spaces in FAT label and support mtools-like labels + + * fs/fat.c (grub_fat_iterate_dir): New function based + on grub_fat_find_dir + (grub_fat_find_dir): use grub_fat_iterate_dir + (grub_fat_label): likewise
fat.c +119 -120
310 lines not on this page · raw message
Applies fine to last SVN
Quoted 9 lines · phcoder
With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' SerbinenkoQuoted 4 lines · phcoder
Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko
Signature · 2 lines
Regards Vladimir 'phcoder' Serbinenko
Bean already said on IRC that this patch is fine with him. If I don't recieve any oppositions in 1 week I consider this patch ok for committment
Quoted 13 lines · phcoder
Applies fine to last SVN
Quoted 9 lines · phcoder
With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' SerbinenkoQuoted 4 lines · phcoder
Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko
Signature · 2 lines
Regards Vladimir 'phcoder' Serbinenko
Commited
Quoted 17 lines · phcoder
Bean already said on IRC that this patch is fine with him. If I don't recieve any oppositions in 1 week I consider this patch ok for committment
Quoted 13 lines · phcoder
Applies fine to last SVN
Quoted 9 lines · phcoder
With this patch fat became case-sensitive which is probably wrong. Corrected version of patch attached Sorry
Vladimir 'phcoder' SerbinenkoQuoted 4 lines · phcoder
Hello. Now the handling of FAT-labels keeps the trailing spaces and ignores VFAT label generated by mlabel tool. Here is the patch to correct this. Unfortunately m$ when user set a mixed case label only uppercase one is saved to FS, moreover m$ keeps the mixed case label in the registry fooling the user. So no way to read these. To test mixed case labels be sure that mlabel reports it as mixed case. Thanks
Vladimir 'phcoder' Serbinenko
Signature · 2 lines
Regards Vladimir 'phcoder' Serbinenko