Skip to contentSkip to conversation

XFS misc patches

PATCH In review Mark Goodwin 4 participants 4 messages Feb 12, 2009 – Feb 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 XFS misc patches

Series of 12 patches, originally by Dave Chinner. These will need forward porting to top-of-tree and careful review. See the description in each individual patch for details of each patch.

01/12 readpage-unwritten-mapping
02/12 xfs-fix-log-io-latency
03/12 xfs-use-meta-io-for-async-metadata
04/12 xfs-inval-page-fixup
05/12 xfs-iolock-on-page-mkwrite
06/12 xfs-non-block-writes-when-frozen
07/12 xfs-non-block-setattr-size-when-frozen
08/12 xfs-inode-search
09/12 xfs-v2-inodes-default
10/12 xfs-inode-writeback-checking
11/12 xfs-inode-swap
12/12 xfs-increase-iclogs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 4 lines · Mark Goodwin

Series of 12 patches, originally by Dave Chinner. These will need forward porting to top-of-tree and careful review. See the description in each individual patch for details of each patch.

Quoted 12 lines

01/12 readpage-unwritten-mapping
02/12 xfs-fix-log-io-latency
03/12 xfs-use-meta-io-for-async-metadata
04/12 xfs-inval-page-fixup
05/12 xfs-iolock-on-page-mkwrite
06/12 xfs-non-block-writes-when-frozen
07/12 xfs-non-block-setattr-size-when-frozen
08/12 xfs-inode-search
09/12 xfs-v2-inodes-default
10/12 xfs-inode-writeback-checking
11/12 xfs-inode-swap
12/12 xfs-increase-iclogs

Mark, thanks a lot for getting these out there. Maybe we can get this stuff to the wiki and track who's willing to look at them.

-Eric

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
In reply to Mark Goodwin
Quoted 6 lines · Mark Goodwin

Series of 12 patches, originally by Dave Chinner. These will need forward porting to top-of-tree and careful review. See the description in each individual patch for details of each patch.

01/12 readpage-unwritten-mapping

Is there any other reason for this except for the slight cleanup? Looks goodish to me and I'll throw it into my QA queue.

Quoted 2 lines

02/12 xfs-fix-log-io-latency
03/12 xfs-use-meta-io-for-async-metadata

Whered did we get stuck on these? IIRC there was some sort of regression on either the AS or deadlinke scheduler, right?

Quoted 1 line

04/12 xfs-inval-page-fixup

Looks good to me, but not really useful until we actually have back tracing in some useable tree..

Quoted 1 line

05/12 xfs-iolock-on-page-mkwrite

Do we have a testcase for those races?

Quoted 1 line

06/12 xfs-non-block-writes-when-frozen

We don't actually ever set O_NDELAY for regular files, so this can't actually be triggered.

Quoted 1 line

07/12 xfs-non-block-setattr-size-when-frozen

I wonder if we should do these kinds of things higher up, e.g. in the vfsmount writer count API in the VFS.

Quoted 1 line

08/12 xfs-inode-search

Interesting idea, but really wants some refactoring of the surrounding code first..

Quoted 1 line

09/12 xfs-v2-inodes-default

Do we really care? There shouldn't be any Linux filesystems with v1 inodes in the wild.

Quoted 1 line

10/12 xfs-inode-writeback-checking

b_io_callback is now in the CRC patch series, and we could add additional checking there. Must say I don't really like the string buffer on stack in that path.

Quoted 1 line

11/12 xfs-inode-swap

Yeah, we need to revisit this eventually. Big qustions is what we want to do with symlinks in an xfs_reno or shrinkfs using this ioctl.

Quoted 1 line

12/12 xfs-increase-iclogs

Interesting idea. But 2MB is much larger than the current log buffer window..

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 6 lines · Mark Goodwin

Series of 12 patches, originally by Dave Chinner. These will need forward porting to top-of-tree and careful review. See the description in each individual patch for details of each patch.

01/12 readpage-unwritten-mapping

Is there any other reason for this except for the slight cleanup? Looks goodish to me and I'll throw it into my QA queue.

Cleanup, may as well use the buffer_unwritten state....

Quoted 5 lines
Quoted 2 lines

02/12 xfs-fix-log-io-latency
03/12 xfs-use-meta-io-for-async-metadata

Whered did we get stuck on these? IIRC there was some sort of regression on either the AS or deadlinke scheduler, right?

optimisations for a specific scheduler that aren't applicable to all. I have to get back to these at some point.

Quoted 4 lines
Quoted 1 line

04/12 xfs-inval-page-fixup

Looks good to me, but not really useful until we actually have back tracing in some useable tree..

Though it will tell use whenever that nasty 'throw away delalloc pages without converting the extent first' problem is hit. That was the main purpose of the patch. Probably good to have that.

Quoted 3 lines
Quoted 1 line

05/12 xfs-iolock-on-page-mkwrite

Do we have a testcase for those races?

IIRC, fsx mixing direct io and mmap will trigger it fairly reliably.

Quoted 4 lines
Quoted 1 line

06/12 xfs-non-block-writes-when-frozen

We don't actually ever set O_NDELAY for regular files, so this can't actually be triggered.

Was for NFS servers to prevent them from locking up all threads on a single fs while a snapshot was in progress on it. There was probably a matching piece to the NFS server write path.

Quoted 1 line
Quoted 1 line

07/12 xfs-non-block-setattr-size-when-frozen

Ditto.

Quoted 2 lines

I wonder if we should do these kinds of things higher up, e.g. in the vfsmount writer count API in the VFS.

Probably be a good idea.

Quoted 4 lines
Quoted 1 line

08/12 xfs-inode-search

Interesting idea, but really wants some refactoring of the surrounding code first..

Yes, needs reworking. But it was always sitting in my QA tree, so the concept seems to be sound. ;)

Quoted 4 lines
Quoted 1 line

09/12 xfs-v2-inodes-default

Do we really care? There shouldn't be any Linux filesystems with v1 inodes in the wild.

Not really. it can be dropped.

Quoted 4 lines
Quoted 1 line

10/12 xfs-inode-writeback-checking

b_io_callback is now in the CRC patch series, and we could add additional checking there.

Yes, that was the intent.

Quoted 2 lines

Must say I don't really like the string
buffer on stack in that path.

Neither do I - it was a quick hack ;)

Quoted 4 lines
Quoted 1 line

11/12 xfs-inode-swap

Yeah, we need to revisit this eventually. Big qustions is what we want to do with symlinks in an xfs_reno or shrinkfs using this ioctl.

Yup.

Quoted 4 lines
Quoted 1 line

12/12 xfs-increase-iclogs

Interesting idea. But 2MB is much larger than the current log buffer window..

No it isn't. We default to 8 log buffers, and when you say logbsize=262144, you have a 2MB window. I should go back and look at this again....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs