Skip to contentSkip to conversation

EXPORT_SYMBOL_GPL(ata_pio_sectors) ?

DISCUSSION Mark Lord 2 participants 3 messages Feb 12, 2009 – Feb 13, 2009 libata

lore
Share & tools
lore

Mark Lord

author
#0 lore raw

Tejun / Jeff,

Any objections if I EXPORT ata_pio_sectors() for use from sata_mv.c ? The code there is complex enough that I'd rather not duplicate it.

It will be needed for an errata workaround that's being worked on, and I'll post a patch for it along with the errata patch once it is ready.

Thanks

#1 lore raw
Quoted 8 lines · Mark Lord

Tejun / Jeff,

Any objections if I EXPORT ata_pio_sectors() for use from sata_mv.c ? The code there is complex enough that I'd rather not duplicate it.

It will be needed for an errata workaround that's being worked on, and I'll post a patch for it along with the errata patch once it is ready.

That's fine...

author
#2 lore raw
Quoted 4 lines · Jeff Garzik
Quoted 3 lines · Mark Lord

Tejun / Jeff,

Any objections if I EXPORT ata_pio_sectors() for use from sata_mv.c ?

..

Quoted 1 line

That's fine...

..

Well, it turns out that EXPORTing ata_pio_queue_task() was even more useful. Patches are now awaiting your queue for 2.6.30.

No sata_mv target mode yet, but it's coming soon.

It appears that the GEN_IIE chips can be used to implement a pretty decent SATA protocol tracer/analyzer too..

Cheers