Skip to contentSkip to conversation

p54: misplaced parentheses

PATCH New Roel Kluin 1 participant 1 message Feb 15, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 p54: misplaced parentheses

Only FIF_FCSFAIL is set due to parentheses

---
// include/net/mac80211.h vi +1133

enum ieee80211_filter_flags {
        FIF_PROMISC_IN_BSS      = 1<<0,
	...
};
drivers/net/wireless/p54/p54common.c +2 -2
index 34561e6..530daee 100644
@@ -1932,8 +1932,8 @@ static void p54_configure_filter(struct ieee80211_hw *dev,
 	struct p54_common *priv = dev->priv;
 
 	*total_flags &= FIF_PROMISC_IN_BSS |
-			(*total_flags & FIF_PROMISC_IN_BSS) ?
-				FIF_FCSFAIL : 0;
+			(*total_flags & FIF_PROMISC_IN_BSS ?
+				FIF_FCSFAIL : 0);
 
 	priv->filter_flags = *total_flags;