Skip to contentSkip to conversation

doc: add deprecation notice for sched changes

PATCH Applied Jasvinder Singh 4 participants 7 messages Apr 24, 2019 – May 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 doc: add deprecation notice for sched changes

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)
doc/guides/rel_notes/deprecation.rst +6 -0
index b47c8c254..051ab5c2a 100644
@@ -79,6 +79,12 @@ Deprecation Notices
 
   The field would be added in v19.08.
 
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+  traffic classes, and subport level configuration of pipes and queues
+  changes will be made to macros, data structures and API functions defined
+  in "rte_sched.h". These changes are aligned to improvements suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+
 * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
   structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
   ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Jasvinder Singh

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

---
  doc/guides/rel_notes/deprecation.rst | 6 ++++++
  1 file changed, 6 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index b47c8c254..051ab5c2a 100644
@@ -79,6 +79,12 @@ Deprecation Notices
 
    The field would be added in v19.08.

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 90

Quoted 10 lines
doc/guides/rel_notes/deprecation.rst +6 -0
 
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+  traffic classes, and subport level configuration of pipes and queues
+  changes will be made to macros, data structures and API functions defined
+  in "rte_sched.h". These changes are aligned to improvements suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+
  * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
    structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
    ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
Acked-by Reshma Pattan
#2 lore raw

29/04/2019 12:31, Mohammad Abdul Awal:

Quoted 8 lines · Jasvinder Singh
Quoted 7 lines

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

Quoted 13 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 86

Quoted 10 lines

---

doc/guides/rel_notes/deprecation.rst +5 -0
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+  traffic classes, and subport level configuration of pipes and queues
+  changes will be made to macros, data structures and API functions defined
+  in "rte_sched.h". These changes are aligned to improvements suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.

There are only 2 acks for this change.
Any other opinion? yes or no?

#3 lore raw
Quoted 39 lines

-----Original Message-----
From: Thomas Monjalon [mailto:[email protected]]
Sent: Monday, May 13, 2019 2:56 PM
To: [email protected]
Cc: Awal, Mohammad Abdul <[email protected]>; Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian <[email protected]>; Yigit, Ferruh <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

29/04/2019 12:31, Mohammad Abdul Awal:

Quoted 17 lines · Jasvinder Singh
Quoted 16 lines

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

---

doc/guides/rel_notes/deprecation.rst +4 -0
+* sched: To allow more traffic classes, flexible mapping of pipe
+queues to
+  traffic classes, and subport level configuration of pipes and
+queues
Quoted 8 lines

doc/guides/rel_notes/deprecation.rst

Quoted 5 lines
doc/guides/rel_notes/deprecation.rst +5 -0
+  changes will be made to macros, data structures and API functions
+defined
+  in "rte_sched.h". These changes are aligned to improvements
+suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
Quoted 5 lines

There are only 2 acks for this change.
Any other opinion? yes or no?

Cristian has provided his ack as well, please see below signed-off line.

#4 lore raw

13/05/2019 15:59, Singh, Jasvinder:

Quoted 26 lines

From: Thomas Monjalon [mailto:[email protected]]

Quoted 25 lines

29/04/2019 12:31, Mohammad Abdul Awal:

Quoted 24 lines · Jasvinder Singh
Quoted 21 lines

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

---

doc/guides/rel_notes/deprecation.rst +9 -0
+* sched: To allow more traffic classes, flexible mapping of pipe
+queues to
+  traffic classes, and subport level configuration of pipes and
+queues
+  changes will be made to macros, data structures and API functions
+defined
+  in "rte_sched.h". These changes are aligned to improvements
+suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

There are only 2 acks for this change.
Any other opinion? yes or no?

Cristian has provided his ack as well, please see below signed-off line.

You are right.
So we get enough acks from the whole team :)

If nobody is against, I will merge it.

#5 lore raw

13/05/2019 16:12, Thomas Monjalon:

Quoted 34 lines

13/05/2019 15:59, Singh, Jasvinder:

Quoted 33 lines

From: Thomas Monjalon [mailto:[email protected]]

Quoted 31 lines

29/04/2019 12:31, Mohammad Abdul Awal:

Quoted 17 lines · Jasvinder Singh
Quoted 16 lines

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

---

doc/guides/rel_notes/deprecation.rst +4 -0
+* sched: To allow more traffic classes, flexible mapping of pipe
+queues to
+  traffic classes, and subport level configuration of pipes and
+queues
Quoted 8 lines

doc/guides/rel_notes/deprecation.rst

Quoted 5 lines
doc/guides/rel_notes/deprecation.rst +5 -0
+  changes will be made to macros, data structures and API functions
+defined
+  in "rte_sched.h". These changes are aligned to improvements
+suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.

There are only 2 acks for this change.
Any other opinion? yes or no?

Quoted 6 lines
Quoted 1 line

Cristian has provided his ack as well, please see below signed-off line.

You are right.
So we get enough acks from the whole team :)

If nobody is against, I will merge it.

Applied, thanks

Acked-by on v1 1/1
#6 lore raw
In reply to Jasvinder Singh
Quoted 9 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Jasvinder Singh
Sent: Wednesday, April 24, 2019 1:37 PM
To: [email protected]
Cc: Dumitrescu, Cristian <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

Quoted 8 lines

Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html