Skip to contentSkip to conversation

sungem: another error printed one too early

PATCH Applied Roel Kluin 2 participants 3 messages Feb 16, 2009 – Mar 4, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 sungem: another error printed one too early

Another error was printed one too early.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/sungem.c +1 -1
index 4918763..8d64b1d 100644
@@ -1157,7 +1157,7 @@ static void gem_pcs_reset(struct gem *gp)
 		if (limit-- <= 0)
 			break;
 	}
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_WARNING "%s: PCS reset bit would not clear.\n",
 		       gp->dev->name);
 }
author
#1 lore raw
Quoted 4 lines · Roel Kluin

Another error was printed one too early.

Signed-off-by Roel Kluin <[email protected]>

---

I am not sure why my script didn't report this earlier.
-----------------------------------------------------
Another error was printed one too early.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/sungem.c +1 -1
index 8d64b1d..0fcb750 100644
@@ -1229,7 +1229,7 @@ static void gem_reset(struct gem *gp)
 			break;
 	} while (val & (GREG_SWRST_TXRST | GREG_SWRST_RXRST));
 
-	if (limit <= 0)
+	if (limit < 0)
 		printk(KERN_ERR "%s: SW reset is ghetto.\n", gp->dev->name);
 
 	if (gp->phy_type == phy_serialink || gp->phy_type == phy_serdes)