Skip to contentSkip to conversation

amd74xx: fix typo in drivers/ide/amd74xx.c

PATCH In review Wei Yongjun 3 participants 3 messages Feb 17, 2009 libata

lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 amd74xx: fix typo in drivers/ide/amd74xx.c

Fix the typo of dev->vendor to dev->device.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/ide/amd74xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ide/amd74xx.c +1 -1
index 69660a4..77267c8 100644
@@ -166,7 +166,7 @@ static unsigned int init_chipset_amd74xx(struct pci_dev *dev)
 	 * Check for broken FIFO support.
 	 */
 	if (dev->vendor == PCI_VENDOR_ID_AMD &&
-	    dev->vendor == PCI_DEVICE_ID_AMD_VIPER_7411)
+	    dev->device == PCI_DEVICE_ID_AMD_VIPER_7411)
 		t &= 0x0f;
 	else
 		t |= 0xf0;
Signature · 1 line
1.5.3.8
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Wei Yongjun

Fix the typo of dev->vendor to dev->device.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/ide/amd74xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ide/amd74xx.c +0 -0
index 69660a4..77267c8 100644

drivers/ide/amd74xx.c static unsigned int init_chipset_amd74xx(struct pci_dev *dev) · line 169

Quoted 5 lines
drivers/ide/amd74xx.c +1 -1
@@ -166,7 +166,7 @@ static unsigned int init_chipset_amd74xx(struct pci_dev *dev)
 	 * Check for broken FIFO support.
 	 */
 	if (dev->vendor == PCI_VENDOR_ID_AMD &&
-	    dev->vendor == PCI_DEVICE_ID_AMD_VIPER_7411)
+	    dev->device == PCI_DEVICE_ID_AMD_VIPER_7411)
Acked-by Jeff Garzik <[email protected]>
#2 lore raw
In reply to Wei Yongjun

Hello.

Quoted 13 lines · Wei Yongjun

Fix the typo of dev->vendor to dev->device.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/ide/amd74xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ide/amd74xx.c +0 -0
index 69660a4..77267c8 100644

drivers/ide/amd74xx.c static unsigned int init_chipset_amd74xx(struct pci_dev *dev) · line 172

Quoted 8 lines
drivers/ide/amd74xx.c +1 -1
@@ -166,7 +166,7 @@ static unsigned int init_chipset_amd74xx(struct pci_dev *dev)
 	 * Check for broken FIFO support.
 	 */
 	if (dev->vendor == PCI_VENDOR_ID_AMD &&
-	    dev->vendor == PCI_DEVICE_ID_AMD_VIPER_7411)
+	    dev->device == PCI_DEVICE_ID_AMD_VIPER_7411)
 		t &= 0x0f;
 	else
 		t |= 0xf0;

Already submitted by Roel Kluin.

MBR, Sergei