acpi: add some missing section markers
PATCH 1/1 acpi: add some missing section markers
early_acpi_os_unmap_memory() is an __init function, and acpi_os_unmap_memory() is allowed to access an __init function until acpi_gbl_permanent_mmap is set up.
drivers/acpi/osl.c +0 -0
@@ -272,7 +272,7 @@ acpi_os_map_memory(acpi_physical_address phys, acpi_size size)
}EXPORT_SYMBOL_GPL(acpi_os_map_memory);
-void acpi_os_unmap_memory(void __iomem * virt, acpi_size size) +void __ref acpi_os_unmap_memory(void __iomem * virt, acpi_size size)
{
if (acpi_gbl_permanent_mmap)
iounmap(virt);@@ -281,7 +281,7 @@ void acpi_os_unmap_memory(void __iomem * virt, acpi_size size) }EXPORT_SYMBOL_GPL(acpi_os_unmap_memory);
-void early_acpi_os_unmap_memory(void __iomem * virt, acpi_size size) +void __init early_acpi_os_unmap_memory(void __iomem * virt, acpi_size size)
{
if (!acpi_gbl_permanent_mmap)
__acpi_unmap_table(virt, size);Quoted 5 lines · Jeremy Fitzhardinge
early_acpi_os_unmap_memory()is an__initfunction, andacpi_os_unmap_memory()is allowed to access an__initfunction untilacpi_gbl_permanent_mmapis set up.Signed-off-by Jeremy Fitzhardinge <[email protected]>
Note, this is modified by tip:x86/acpi, so if Len applies it to the ACPI tree we'll generate conflicts. Since the problem itself has been generated by the 6 commits in tip:x86/acpi, if Len is fine with it i'd like to apply your fix there.
Ingo
Quoted 9 lines · Ingo Molnar
Quoted 4 lines · Jeremy Fitzhardinge
early_acpi_os_unmap_memory()is an__initfunction, andacpi_os_unmap_memory()is allowed to access an__initfunction untilacpi_gbl_permanent_mmapis set up.Signed-off-by Jeremy Fitzhardinge <[email protected]>Note, this is modified by tip:x86/acpi, so if Len applies it to the ACPI tree we'll generate conflicts. Since the problem itself has been generated by the 6 commits in tip:x86/acpi, if Len is fine with it i'd like to apply your fix there.
Sorry, I'd forgotten what path those patches were taking; I just blindly applied the "ACPI=Len" pattern.
J
Quoted 11 lines · Jeremy Fitzhardinge
Quoted 10 lines · Ingo Molnar
Quoted 6 lines · Jeremy Fitzhardinge
early_acpi_os_unmap_memory()is an__initfunction, andacpi_os_unmap_memory()is allowed to access an__initfunction untilacpi_gbl_permanent_mmapis set up.Signed-off-by Jeremy Fitzhardinge <[email protected]>
Quoted 7 lines
Quoted 4 lines
Note, this is modified by tip:x86/acpi, so if Len applies it to the ACPI tree we'll generate conflicts. Since the problem itself has been generated by the 6 commits in tip:x86/acpi, if Len is fine with it i'd like to apply your fix there.
Sorry, I'd forgotten what path those patches were taking; I just blindly applied the "ACPI=Len" pattern.
That was the correct pattern to apply in any case, as it modifies drivers/acpi/.
Ingo