Skip to contentSkip to conversation

staging: ! x & y problem in inactive code

PATCH In review Roel Kluin 2 participants 2 messages Feb 19, 2009 – Feb 25, 2009 Staging

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 staging: ! x & y problem in inactive code

This is the only ! x & y problem I found that weren't already reported, except by me in http://lkml.org/lkml/2009/1/17/69 but maybe you overlooked it?

It's in comment, but maybe this was the reason why it was commented out to begin with?

Gr,

Roel --------------------------->8-------------8<------------------------------ Fix ! x & y problem in inactivated code

---

drivers/staging/rtl8187se/r8180_core.c +1 -1
index 9453495..18a7bad 100644
@@ -3161,7 +3161,7 @@ void rtl8180_prepare_beacon(struct net_device *dev)
 		return ;
 
 	}
-	//while(! *tail & (1<<31)){
+	//while(! (*tail & (1<<31))){
 		*tail= 0; // zeroes header
 
 		*tail = *tail| (1<<29) ; //fist segment of the packet
#1 lore raw
Quoted 3 lines · Roel Kluin

This is the only ! x & y problem I found that weren't already reported, except by me in http://lkml.org/lkml/2009/1/17/69 but maybe you overlooked it?

Sorry, got it now, they should all be fixed up, right?

thanks,

greg k-h