Skip to contentSkip to conversation

btrfs: return inode to fs when btrfs_new_inode fails

PATCH New Shen Feng 1 participant 1 message Feb 25, 2009 Btrfs file system

lore
Share & tools
lore

Shen Feng

author
#0 lore raw

PATCH 1/1 btrfs: return inode to fs when btrfs_new_inode fails

btrfs_new_inode doesn't call iput to return inode to fs when it fails.

---
 fs/btrfs/inode.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
fs/btrfs/inode.c +4 -1
index 3cee77a..2cae014 100644
@@ -3443,8 +3443,10 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
 
 	if (dir) {
 		ret = btrfs_set_inode_index(dir, index);
-		if (ret)
+		if (ret) {
+			iput(inode);
 			return ERR_PTR(ret);
+		}
 	}
 	/*
 	 * index_cnt is ignored for everything but a dir,
@@ -3525,6 +3527,7 @@ fail:
 	if (dir)
 		BTRFS_I(dir)->index_cnt--;
 	btrfs_free_path(path);
+	iput(inode);
 	return ERR_PTR(ret);
 }
 
Signature · 1 line
1.6.0.6