Skip to contentSkip to conversation

netfilter: remove some pointless conditionals before kfree_skb()

PATCH New Wei Yongjun 1 participant 1 message Feb 25, 2009

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 netfilter: remove some pointless conditionals before kfree_skb()

Remove some pointless conditionals before kfree_skb().

Signed-off-by Wei Yongjun <[email protected]>
---
 net/decnet/netfilter/dn_rtmsg.c         |    3 +--
 net/ipv6/netfilter/nf_conntrack_reasm.c |    3 +--
 net/netfilter/nfnetlink_queue.c         |    3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)
net/decnet/netfilter/dn_rtmsg.c +1 -2
index 6d2bd32..17cbc4c 100644
@@ -53,8 +53,7 @@ static struct sk_buff *dnrmg_build_message(struct sk_buff *rt_skb, int *errp)
 	return skb;
 
 nlmsg_failure:
-	if (skb)
-		kfree_skb(skb);
+	kfree_skb(skb);
 	*errp = -ENOMEM;
 	if (net_ratelimit())
 		printk(KERN_ERR "dn_rtmsg: error creating netlink message\n");
net/ipv6/netfilter/nf_conntrack_reasm.c +1 -2
index ed4d79a..37f7954 100644
@@ -112,8 +112,7 @@ static unsigned int nf_hashfn(struct inet_frag_queue *q)
 
 static void nf_skb_free(struct sk_buff *skb)
 {
-	if (NFCT_FRAG6_CB(skb)->orig)
-		kfree_skb(NFCT_FRAG6_CB(skb)->orig);
+	kfree_skb(NFCT_FRAG6_CB(skb)->orig);
 }
 
 /* Memory Tracking Functions. */
net/netfilter/nfnetlink_queue.c +1 -2
index 8c86011..6f4c970 100644
@@ -379,8 +379,7 @@ nfqnl_build_packet_message(struct nfqnl_instance *queue,
 
 nlmsg_failure:
 nla_put_failure:
-	if (skb)
-		kfree_skb(skb);
+	kfree_skb(skb);
 	if (net_ratelimit())
 		printk(KERN_ERR "nf_queue: error creating packet message\n");
 	return NULL;
Signature · 1 line
1.5.3.8