Skip to contentSkip to conversation

snd-powermac: timeout reaches -1

PATCH In review Roel Kluin 2 participants 2 messages Feb 25, 2009 Sound

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 snd-powermac: timeout reaches -1

If unsuccessful, timeout reaches -1 after the loop.

---

sound/ppc/burgundy.c +1 -1
index f860d39..45a7629 100644
@@ -35,7 +35,7 @@ snd_pmac_burgundy_busy_wait(struct snd_pmac *chip)
 	int timeout = 50;
 	while ((in_le32(&chip->awacs->codec_ctrl) & MASK_NEWECMD) && timeout--)
 		udelay(1);
-	if (! timeout)
+	if (timeout < 0)
 		printk(KERN_DEBUG "burgundy_busy_wait: timeout\n");
 }
#1 lore raw

At Wed, 25 Feb 2009 13:40:26 +0100,

Quoted 4 lines · Roel Kluin

If unsuccessful, timeout reaches -1 after the loop.

Applied now. Thanks.

Takashi

Quoted 15 lines

---

sound/ppc/burgundy.c +1 -1
index f860d39..45a7629 100644
@@ -35,7 +35,7 @@ snd_pmac_burgundy_busy_wait(struct snd_pmac *chip)
 	int timeout = 50;
 	while ((in_le32(&chip->awacs->codec_ctrl) & MASK_NEWECMD) && timeout--)
 		udelay(1);
-	if (! timeout)
+	if (timeout < 0)
 		printk(KERN_DEBUG "burgundy_busy_wait: timeout\n");
 }