pata_it821x: resume from hibernation fails with RAID volume
PATCH 4/4 pata_it821x: resume from hibernation fails with RAID volume
From: Ondrej Zary <[email protected]>
Hibernation didn't work for me since I started to use IT8212 controller. I did some debugging (booting with no_console_suspend init=/bin/sh).
Found that resume fails (2.6.28) with "serial number mismatch 'some garbage' != 'some other garbage'" and "revalidation failed" messages. That's because the controller firmware fills different serial number in the IDENTIFY every boot.
The patch below fixes the resume simply clearing the serial number. The proper fix would be probably to fill in the serial number of the RAID volume instead. I assume that there must be something like that stored on the drives but I don't know where.
Fix resume on pata_it821x RAID volume by clearing the serial number in IDENTIFY data, which is otherwise different on each boot.
---
drivers/ata/pata_it821x.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/ata/pata_it821x.c renamed from drivers/ata/pata_it821x.c~pata_it821x-resume-from-hibernation-fails-with-raid-volume +3 -0
@@ -557,6 +557,9 @@ static unsigned int it821x_read_id(struc id[83 ] |=0x4400 ;/* Word 83 is valid and LBA48 */ id[86 ] |=0x0400 ;/* LBA48 on */ id[ATA_ID_MAJOR_VER ] |=0x1F ; +/* Clear the serial number because it's different each boot +which breaks validation on resume */ +memset (&id[ATA_ID_SERNO ],0x20 ,ATA_ID_SERNO_LEN ); }return err_mask; }
_
Jeff Garzik
AppliedQuoted 16 lines · [email protected] wrote:
From: Ondrej Zary <[email protected]>
Hibernation didn't work for me since I started to use IT8212 controller. I did some debugging (booting with
no_console_suspendinit=/bin/sh).Found that resume fails (2.6.28) with "serial number mismatch 'some
garbage' != 'some other garbage'" and "revalidation failed" messages. That's because the controller firmware fills different serial number in the IDENTIFY every boot.The patch below fixes the resume simply clearing the serial number. The proper fix would be probably to fill in the serial number of the RAID volume instead. I assume that there must be something like that stored on the drives but I don't know where.
Fix resume on
pata_it821xRAID volume by clearing the serial number in IDENTIFY data, which is otherwise different on each boot.
Quoted 9 lines
Signed-off-by Ondrej Zary <[email protected]>Acked-by Alan Cox <[email protected]>Cc Jeff Garzik <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
drivers/ata/pata_it821x.c | 3 +++ 1 file changed, 3 insertions(+)
applied