Fix for running examples on OMAP3 EVM board
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Example binaries to be downloaded to 0x80300000 for OMAP3 EVMs.
--- examples/Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
examples/Makefile +4 -0
@@ -36,10 +36,14 @@ else ifeq ($(CPU),omap3) LOAD_ADDR = 0x80300000 else +ifeq ($(CPU),arm_cortexa8) +LOAD_ADDR = 0x80300000 +else LOAD_ADDR = 0xc100000 endif endif endif +endif ifeq ($(ARCH),mips) LOAD_ADDR = 0x80200000 -T mips.lds
Signature · 1 line
1.5.6
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Manikandan Pillai said the following on 03/03/2009 05:40 AM:
Quoted 12 lines
Example binaries to be downloaded to
0x80300000for OMAP3 EVMs.Signed-off-by Manikandan Pillai <[email protected]>--- examples/Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)examples/Makefile +0
-0
examples/Makefile else · line 42
Quoted 7 lines
examples/Makefile +3
-0@@ -36,10 +36,14 @@ else ifeq ($(CPU),omap3) LOAD_ADDR = 0x80300000 else +ifeq ($(CPU),arm_cortexa8) +LOAD_ADDR = 0x80300000 +else
I am bit confused here.. first we say $(CPU) omap3...EVM is based on omap3 rt?
the second change is not valid -> cortex_a8 -> we might have future platforms which have cortex. they need not use the same memory map as OMAP does. this is not valid change. NAK from me.
Regards,
Nishanth Menon
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Quoted 17 lines · Nishanth Menon
Manikandan Pillai said the following on 03/03/2009 05:40 AM:
Quoted 16 lines
Example binaries to be downloaded to
0x80300000for OMAP3 EVMs.Signed-off-by Manikandan Pillai <[email protected]>--- examples/Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)examples/Makefile +1
-0@@ -36,10 +36,14 @@ else ifeq ($(CPU),omap3) LOAD_ADDR = 0x80300000 else +ifeq ($(CPU),arm_cortexa8)
Quoted 8 lines
examples/Makefile else · line 47
Quoted 3 lines
examples/Makefile +2
-0+LOAD_ADDR = 0x80300000 +elseI am bit confused here.. first we say $(CPU) omap3...EVM is based on omap3 rt?
the second change is not valid ->cortex_a8-> we might have future platforms which have cortex. they need not use the same memory map as OMAP does. this is not valid change. NAK from me.
Even if it becomes boring, I agree to Nishanth again. NACK from me, too.
Best regards
Dirk
Pillai
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Hi all,
For the EVM board,
$BOARD = evm $CPU = arm_cortexa8 and $ARCH = arm.
$VENDOR = omap3 and $SOC = omap3
I can change the check to check BOARD so that it is applicable only To OMAP3 EVMs.
ifeq ($(BOARD),evm)LOAD_ADDR = 0x80300000
else
Regards
Mani
Quoted 39 lines
-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Wednesday, March 04, 2009 5:47 AM
To: u-boot at lists.denx.de
Cc: Nishanth Menon; Pillai, Manikandan
Subject: Re: [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM boardQuoted 17 lines · Nishanth Menon
Manikandan Pillai said the following on 03/03/2009 05:40 AM:
Quoted 16 lines
Example binaries to be downloaded to
0x80300000for OMAP3 EVMs.Signed-off-by Manikandan Pillai <[email protected]>--- examples/Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)examples/Makefile +1
-0@@ -36,10 +36,14 @@ else ifeq ($(CPU),omap3) LOAD_ADDR = 0x80300000 else +ifeq ($(CPU),arm_cortexa8)Quoted 8 lines
examples/Makefile else · line 47
Quoted 3 lines
examples/Makefile +2
-0+LOAD_ADDR = 0x80300000 +elseI am bit confused here.. first we say $(CPU) omap3...EVM is based on omap3 rt?
the second change is not valid ->cortex_a8-> we might have future platforms which have cortex. they need not use the same memory map as OMAP does. this is not valid change. NAK from me.Even if it becomes boring, I agree to Nishanth again. NACK from me, too.
Best regards
Dirk
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Pillai, Manikandan said the following on 03/04/2009 06:57 AM:
Quoted 2 lines
Hi all,
please dont top post.
Quoted 5 lines
For the EVM board,
$BOARD = evm $CPU =
arm_cortexa8and $ARCH = arm.
$VENDOR = omap3 and $SOC = omap3
Quoted 7 lines
I can change the check to check BOARD so that it is applicable only To OMAP3 EVMs.
ifeq ($(BOARD),evm)
LOAD_ADDR=0x80300000
else
what is so special about evm? ;) if we have an exception from the current boards supported, lets go ahead and do it.. mebbe the right fix would be replace $CPU, omap3 with $SOC,omap3? Regards,
Nishanth Menon
Pillai
PATCH 1/1 Fix for running examples on OMAP3 EVM board
Hi,
Fine with me. I can change the CPU-omap3 to SOC-omap3.
Quoted 28 lines
-----Original Message-----
From: Nishanth Menon [mailto:menon.nishanth at gmail.com]
Sent: Wednesday, March 04, 2009 11:49 AM
To: Pillai, Manikandan
Cc: Dirk Behme; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 1/1] Fix for running examples on OMAP3 EVM boardPillai, Manikandan said the following on 03/04/2009 06:57 AM:
Quoted 2 lines
Hi all,
please dont top post.
Quoted 5 lines
For the EVM board,
$BOARD = evm $CPU =
arm_cortexa8and $ARCH = arm.
$VENDOR = omap3 and $SOC = omap3Quoted 7 lines
I can change the check to check BOARD so that it is applicable only To OMAP3 EVMs.
ifeq ($(BOARD),evm)
LOAD_ADDR=0x80300000
elsewhat is so special about evm? ;) if we have an exception from the current boards supported, lets go ahead and do it.. mebbe the right fix would be replace $CPU, omap3 with $SOC,omap3? Regards,
Nishanth Menon
PATCH 1/1 Fix for running examples on OMAP3 EVM board
In reply to PillaiQuoted 7 lines · Manikandan
Hi all,
For the EVM board,
$BOARD = evm $CPU =
arm_cortexa8and $ARCH = arm.
$VENDOR = omap3 and $SOC = omap3
Quoted 7 lines
I can change the check to check BOARD so that it is applicable only To OMAP3 EVMs.
ifeq ($(BOARD),evm)
LOAD_ADDR=0x80300000
else
NACK
what is so special with evm?
and stop to add more and more ifeq in the example/Makefile
please create a EXAMPLE_LOAD_ADDR
that could be overwrite in followaing order
ARCH
CPU
SOC
BOARD
via the corresponding config.mk
Best Regards,
J.