Skip to contentSkip to conversation

cfg80211: test before subtraction on unsigned

PATCH New Roel Kluin 1 participant 1 message Mar 3, 2009 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 cfg80211: test before subtraction on unsigned

freq_diff is unsigned, so test before subtraction

Signed-off-by Roel Kluin <[email protected]>

---

net/wireless/reg.c +2 -1
index 85c9034..bd0a16c 100644
@@ -380,7 +380,8 @@ static bool is_valid_reg_rule(const struct ieee80211_reg_rule *rule)
 
 	freq_diff = freq_range->end_freq_khz - freq_range->start_freq_khz;
 
-	if (freq_diff <= 0 || freq_range->max_bandwidth_khz > freq_diff)
+	if (freq_range->end_freq_khz <= freq_range->start_freq_khz ||
+			freq_range->max_bandwidth_khz > freq_diff)
 		return false;
 
 	return true;