Skip to contentSkip to conversation

ext2_* in bitops.h

DISCUSSION Andy Grover 2 participants 2 messages Mar 4, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

Can the ext2_* definitions in arch/powerpc/include/asm/bitops.h be replaced with:

#include <include/asm-generic/bitops/ext2-non-atomic.h> #include <include/asm-generic/bitops/ext2-atomic.h>

?

Also, can the bitop swizzling (starting at line 351) be removed by including include/asm-generic/bitops/le.h? It looks very similar if not identical.

I'm afraid I don't have a ppc to test on so I wanted to see what you all thought.

Regards -- Andy

#1 lore raw
Quoted 8 lines · Andy Grover

Hi,

Can the ext2_* definitions in arch/powerpc/include/asm/bitops.h be replaced with:

#include <include/asm-generic/bitops/ext2-non-atomic.h> #include <include/asm-generic/bitops/ext2-atomic.h>

Quoted 8 lines

?

Also, can the bitop swizzling (starting at line 351) be removed by including include/asm-generic/bitops/le.h? It looks very similar if not identical.

I'm afraid I don't have a ppc to test on so I wanted to see what you all thought.

I suppose you are right, I'll have a closer look.

Cheers,
Ben.