Skip to contentSkip to conversation

NFSD: fix handling of unsupported nfsv4 ops

PATCH In review Benny Halevy 2 participants 4 messages Feb 26, 2009 – Mar 6, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover NFSD: fix handling of unsupported nfsv4 ops

Both patches fix issues I introduced in 2.6.27.
The first one is more crucial to get to the 2.6.2{7,8} stable streams but while at it, I'd pull both.
This was triggered in connectathon with the Sun OpenSolaris client trying to read extended attrs (when copying a file). This translates to a NFS4 OP_OPENATTR which caused our server to barf.

[PATCH 1/2] NFSD: provide encode routine for OP_OPENATTR
[PATCH 2/2] NFSD: return nfsv4 error code nfserr_notsupp rather than nfsv[23]'s nfserr_opnotsupp

Benny

#1 lore raw
Quoted 6 lines · Benny Halevy

Both patches fix issues I introduced in 2.6.27.
The first one is more crucial to get to the 2.6.2{7,8} stable streams but while at it, I'd pull both.
This was triggered in connectathon with the Sun OpenSolaris client trying to read extended attrs (when copying a file). This translates to a NFS4 OP_OPENATTR which caused our server to barf.

Thanks! But, sorry, somehow I didn't get both of these (probably a screwup on my end); would you mind resending?

Also, have you checked to make sure there aren't any other holes in our list of operations?

--b.

Quoted 5 lines

[PATCH 1/2] NFSD: provide encode routine for OP_OPENATTR
[PATCH 2/2] NFSD: return nfsv4 error code nfserr_notsupp rather than nfsv[23]'s nfserr_opnotsupp

Benny

#2 lore raw
Quoted 10 lines · J. Bruce Fields
Quoted 6 lines · Benny Halevy

Both patches fix issues I introduced in 2.6.27.
The first one is more crucial to get to the 2.6.2{7,8} stable streams but while at it, I'd pull both.
This was triggered in connectathon with the Sun OpenSolaris client trying to read extended attrs (when copying a file). This translates to a NFS4 OP_OPENATTR which caused our server to barf.

Thanks! But, sorry, somehow I didn't get both of these (probably a screwup on my end); would you mind resending?

Just did.

Quoted 3 lines

Also, have you checked to make sure there aren't any other holes in our list of operations?

Yup. OPENATTR was the only hole I found.

Benny

Quoted 7 lines

--b.

Quoted 4 lines

[PATCH 1/2] NFSD: provide encode routine for OP_OPENATTR
[PATCH 2/2] NFSD: return nfsv4 error code nfserr_notsupp rather than nfsv[23]'s nfserr_opnotsupp

Benny

#3 lore raw
In reply to J. Bruce Fields
Quoted 10 lines · bfields
Quoted 6 lines · Benny Halevy

Both patches fix issues I introduced in 2.6.27.
The first one is more crucial to get to the 2.6.2{7,8} stable streams but while at it, I'd pull both.
This was triggered in connectathon with the Sun OpenSolaris client trying to read extended attrs (when copying a file). This translates to a NFS4 OP_OPENATTR which caused our server to barf.

Thanks! But, sorry, somehow I didn't get both of these (probably a screwup on my end); would you mind resending?

Both applied now, thanks.--b.